From 0cec951321d9bf5f71540dc8e7bcfae4122eb0c7 Mon Sep 17 00:00:00 2001 From: Danny Coates Date: Thu, 30 Mar 2017 15:00:57 -0700 Subject: [PATCH] run the selector js on document_end instead of document_idle. fixes #2525 --- addon/webextension/background/selectorLoader.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/addon/webextension/background/selectorLoader.js b/addon/webextension/background/selectorLoader.js index b9f0c93655..81fc86aeda 100644 --- a/addon/webextension/background/selectorLoader.js +++ b/addon/webextension/background/selectorLoader.js @@ -22,7 +22,8 @@ window.selectorLoader = (function () { exports.unloadIfLoaded = function (tabId) { return browser.tabs.executeScript(tabId, { - code: "window.selectorLoader && window.selectorLoader.unloadModules()" + code: "window.selectorLoader && window.selectorLoader.unloadModules()", + runAt: "document_start" }).then(result => { return result && result.toString() === "true"; }); @@ -32,7 +33,10 @@ window.selectorLoader = (function () { let lastPromise = Promise.resolve(null); scripts.forEach((file) => { lastPromise = lastPromise.then(() => { - return browser.tabs.executeScript(tabId, {file}) + return browser.tabs.executeScript(tabId, { + file, + runAt: "document_end" + }) .catch((error) => { console.error("error in script:", file, error); error.scriptName = file;