Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spot Light intensity uses degrees rather than candela #986

Closed
robertlong opened this issue Jun 30, 2020 · 3 comments · Fixed by #1094
Closed

Spot Light intensity uses degrees rather than candela #986

robertlong opened this issue Jun 30, 2020 · 3 comments · Fixed by #1094
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@robertlong
Copy link
Contributor

We need to change the unit of the input.
@robertlong robertlong added bug Something isn't working good first issue Good for newcomers labels Jun 30, 2020
@sardug10
Copy link
Contributor

sardug10 commented Feb 1, 2021

Hey, I am new to open source contributions. Is this a good issue to start with?

@robertlong
Copy link
Contributor Author

Yeah, definitely a good one. It just needs to be changed here:
https://github.com/mozilla/Spoke/blob/master/src/ui/properties/SpotLightNodeEditor.js#L61

@sardug10
Copy link
Contributor

sardug10 commented Feb 1, 2021

Yeah, definitely a good one. It just needs to be changed here:
https://github.com/mozilla/Spoke/blob/master/src/ui/properties/SpotLightNodeEditor.js#L61

Hey, instead of unit="°" , I just have to change it to unit="cd". Is it?😃

@sardug10 sardug10 mentioned this issue Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated unit of Spot Light Intensity sardug10/Spoke
2 participants
@robertlong @sardug10