Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using port 3000 for addons-frontend in Docker #6520

Closed
kumar303 opened this issue Mar 28, 2019 · 4 comments · Fixed by mozilla/addons-frontend#9956
Closed

Stop using port 3000 for addons-frontend in Docker #6520

kumar303 opened this issue Mar 28, 2019 · 4 comments · Fixed by mozilla/addons-frontend#9956
Assignees
Labels
neverstale Use this to tell stalebot to not touch this issue. Should be used infrequently. qa:not_needed repository:addons-server Issue relating to addons-server
Milestone

Comments

@kumar303
Copy link
Contributor

When running a docker image for local development of addons-server, addons-frontend is served on port 3000:

https://github.com/mozilla/addons-server/blob/9ea562f6b4ff7a58d2af69cfa6285f935660ba69/docker-compose.yml#L98-L100

This conflicts with the same port we use for local development of addons-frontend which runs directly from Node.js without Docker.

Let's choose a different port for addons-frontend in Docker

On macOS, this was confusing because Docker uses IPv6 to bind to localhost and that means there are no errors when Node.js starts up on the host machine. It happily binds to port 3000 and both servers run side by side on the same port. Firefox Nightly, Chrome, and curl would connect to Docker via http://localhost:3000 but my Firefox Release would connect to the locally running Node.js server.

@stale stale bot added the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Oct 16, 2019
@EnTeQuAk
Copy link
Contributor

I quickly looked into this. That option can be set through environment variables so it's easy enough to do.

I'm wondering though, is PROXY_PORT (which defaults to 3000) the only port that needs changing? Webpack starts it's server on 3001 which sounds to me like that should be changed for the addons-frontend image too.

@stale stale bot removed the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Oct 16, 2019
@kumar303
Copy link
Contributor Author

Yeah, the webpack port probably needs changing, too. Also, keep in mind that FxA login redirects are currently tied to port number for local development.

@stale stale bot added the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Apr 13, 2020
@diox diox added the neverstale Use this to tell stalebot to not touch this issue. Should be used infrequently. label Apr 13, 2020
@mozilla mozilla deleted a comment from stale bot Apr 13, 2020
@stale stale bot removed the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Apr 13, 2020
@mozilla mozilla deleted a comment from stale bot Apr 13, 2020
@willdurand willdurand self-assigned this Jan 7, 2021
@willdurand willdurand added this to the 2021.01.14 milestone Jan 7, 2021
@willdurand
Copy link
Member

We're not going to change the port in addons-server actually. We will update the config of addons-frontend to use a different port when used in combination with addons-server.

@ioanarusiczki
Copy link

@willdurand In case qa can check this on AMO dev please add some STR
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neverstale Use this to tell stalebot to not touch this issue. Should be used infrequently. qa:not_needed repository:addons-server Issue relating to addons-server
Development

Successfully merging a pull request may close this issue.

7 participants