-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using port 3000 for addons-frontend in Docker #6520
Comments
I quickly looked into this. That option can be set through environment variables so it's easy enough to do. I'm wondering though, is |
Yeah, the webpack port probably needs changing, too. Also, keep in mind that FxA login redirects are currently tied to port number for local development. |
We're not going to change the port in addons-server actually. We will update the config of addons-frontend to use a different port when used in combination with addons-server. |
@willdurand In case qa can check this on AMO dev please add some STR |
When running a docker image for local development of
addons-server
,addons-frontend
is served on port 3000:https://github.com/mozilla/addons-server/blob/9ea562f6b4ff7a58d2af69cfa6285f935660ba69/docker-compose.yml#L98-L100
This conflicts with the same port we use for local development of
addons-frontend
which runs directly from Node.js without Docker.Let's choose a different port for
addons-frontend
in DockerOn macOS, this was confusing because Docker uses IPv6 to bind to localhost and that means there are no errors when Node.js starts up on the host machine. It happily binds to port 3000 and both servers run side by side on the same port. Firefox Nightly, Chrome, and curl would connect to Docker via http://localhost:3000 but my Firefox Release would connect to the locally running Node.js server.
The text was updated successfully, but these errors were encountered: