From 12793a206a5e684af61ae1535f4c80d47f24caba Mon Sep 17 00:00:00 2001 From: Stephanie Hobson Date: Wed, 11 Sep 2024 11:04:22 -0700 Subject: [PATCH] text fixes --- bedrock/contentful/api.py | 7 ++++--- bedrock/newsletter/tests/test_views.py | 2 +- bedrock/products/tests/test_helper_misc.py | 6 +++--- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/bedrock/contentful/api.py b/bedrock/contentful/api.py index edddeb5463e..77f415aa332 100644 --- a/bedrock/contentful/api.py +++ b/bedrock/contentful/api.py @@ -294,9 +294,10 @@ def render(self, node): if url.netloc != "www.mozilla.org": # add security measures rel = ' rel="external noopener"' - # add analytics - cta_text = _make_plain_text(node) - data_cta = f' data-cta-text="{cta_text}"' + + # add analytics + cta_text = _make_plain_text(node) + data_cta = f' data-cta-text="{cta_text}"' return f'{self._render_content(node)}' diff --git a/bedrock/newsletter/tests/test_views.py b/bedrock/newsletter/tests/test_views.py index 0a0e8dbbcc2..74a8d618d58 100644 --- a/bedrock/newsletter/tests/test_views.py +++ b/bedrock/newsletter/tests/test_views.py @@ -190,7 +190,7 @@ def test_shows_form_single(self): doc = pq(resp.content) self.assertTrue(doc("#newsletter-form")) self.assertTrue(doc('input[value="mozilla-foundation"]')) - self.assertEqual(doc("#newsletter-submit")[0].attrib["data-cta-type"], "Newsletter-mozilla-foundation") + self.assertEqual(doc("#newsletter-submit")[0].attrib["data-cta-text"], "Newsletter Sign Up") @patch("bedrock.newsletter.views.basket") def test_returns_success(self, basket_mock): diff --git a/bedrock/products/tests/test_helper_misc.py b/bedrock/products/tests/test_helper_misc.py index 8bbcd55394c..74bfe732e5c 100644 --- a/bedrock/products/tests/test_helper_misc.py +++ b/bedrock/products/tests/test_helper_misc.py @@ -1666,7 +1666,7 @@ def test_vpn_product_referral_link(self): expected = ( 'Get Mozilla VPN' + 'data-cta-text="Get Mozilla VPN">Get Mozilla VPN' ) self.assertEqual(markup, expected) @@ -1682,7 +1682,7 @@ def test_vpn_product_referral_link_pricing_page(self): expected = ( 'Get Mozilla VPN' + 'data-cta-text="Get Mozilla VPN" data-cta-type="vpn">Get Mozilla VPN' ) self.assertEqual(markup, expected) @@ -1699,6 +1699,6 @@ def test_vpn_product_referral_link_optional_params(self): expected = ( 'Get Mozilla VPN' + 'data-cta-text="Get Mozilla VPN" data-cta-type="vpn">Get Mozilla VPN' ) self.assertEqual(markup, expected)