From 60c0fc26d25e9bffa1d73dd378d5f14b6de83b56 Mon Sep 17 00:00:00 2001 From: Alex Gibson Date: Mon, 25 Sep 2023 20:20:41 +0100 Subject: [PATCH] Remove Glean custom page view ping (Fixes #13652) (#13689) --- docs/attribution/0001-analytics.rst | 3 +-- glean/pings.yaml | 14 -------------- media/js/glean/page.es6.js | 3 --- package.json | 4 ++-- 4 files changed, 3 insertions(+), 21 deletions(-) delete mode 100644 glean/pings.yaml diff --git a/docs/attribution/0001-analytics.rst b/docs/attribution/0001-analytics.rst index e89830d62c5..9f4210cd762 100644 --- a/docs/attribution/0001-analytics.rst +++ b/docs/attribution/0001-analytics.rst @@ -382,8 +382,7 @@ Defining metrics and pings All of the data we send to the Glean pipeline is defined in :abbr:`YAML (Yet Another Markup Language)` schema files in the ``./glean/`` project root directory. The ``metrics.yaml`` file defines all the different -metrics types and events we record, and the ``pings.yaml`` file defines -any custom pings we use to send collections of individual metrics. +metrics types and events we record. .. Note:: diff --git a/glean/pings.yaml b/glean/pings.yaml deleted file mode 100644 index 51d0f7261e6..00000000000 --- a/glean/pings.yaml +++ /dev/null @@ -1,14 +0,0 @@ ---- -$schema: moz://mozilla.org/schemas/glean/pings/2-0-0 - -page-view: - description: | - A ping which is sent every time a page is viewed. - include_client_id: true - send_if_empty: false - bugs: - - https://github.com/mozilla/bedrock/issues/10746 - data_reviews: - - https://bugzilla.mozilla.org/show_bug.cgi?id=1767442 - notification_emails: - - marketing-websites-team@mozilla.com diff --git a/media/js/glean/page.es6.js b/media/js/glean/page.es6.js index 83661a1ad53..ff42516a307 100644 --- a/media/js/glean/page.es6.js +++ b/media/js/glean/page.es6.js @@ -6,7 +6,6 @@ import * as page from '../libs/glean/page.js'; import Utils from './utils.es6'; -import { pageView as pageViewPing } from '../libs/glean/pings.js'; const defaultParams = { utm_source: '', @@ -50,8 +49,6 @@ function initPageView() { } page.hit.record(); - - pageViewPing.submit(); } function pageEvent(obj) { diff --git a/package.json b/package.json index 575375b8eac..e60d48da67a 100644 --- a/package.json +++ b/package.json @@ -72,8 +72,8 @@ "prettier-check": "prettier --check .", "stylelint-fix": "./node_modules/.bin/stylelint \"media/css/**/*.{css,scss}\" --fix", "format": "npm run prettier && npm run stylelint-fix", - "glean-lint": "glean glinter glean/metrics.yaml glean/pings.yaml", - "glean": "npm run glean-lint && glean translate glean/metrics.yaml glean/pings.yaml -f javascript -o media/js/libs/glean/" + "glean-lint": "glean glinter glean/metrics.yaml", + "glean": "npm run glean-lint && glean translate glean/metrics.yaml -f javascript -o media/js/libs/glean/" }, "browserslist": [ "defaults",