Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsafe-eval & unsafe-inline from script-src #14828

Open
Tracked by #11943
robhudson opened this issue Jul 15, 2024 · 3 comments
Open
Tracked by #11943

Remove unsafe-eval & unsafe-inline from script-src #14828

robhudson opened this issue Jul 15, 2024 · 3 comments

Comments

@robhudson
Copy link
Member

robhudson commented Jul 15, 2024

As mentioned in the comments, "The last inlined style was removed in #14614 and I couldn't find any more of such occurrences so hopefully the unsafes can be gone soon."

@stevejalim
Copy link
Collaborator

Forgive me if this is already thought of, but the Wagtail admin may well still need unsafe-eval - would you mind checking and adding to the CMS-only CSP if need be?

@robhudson
Copy link
Member Author

Thanks for reminding me. And yeah, I can fire up the admin and check it.

@robhudson robhudson changed the title Remove unsafe-eval from script-src Remove unsafe-eval & unsafe-inline from script-src Jul 15, 2024
@janbrasna
Copy link
Contributor

The Wagtail-specific excludes were added in #14869 — and I have just a naïve followup question — normally the excludes would be for anything under /cms-admin/*, save for its login screen — to safeguard the actual login surface from potential injection etc. … Is that a valid concern here, and viable to address, or it's okay to allow the unsafes & ancestors even on the login page, as currently proposed in #14831?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants