Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all records in /hibp/breaches endpoint have LogoUrl #2827

Open
pdehaan opened this issue Feb 11, 2023 · 0 comments
Open

Not all records in /hibp/breaches endpoint have LogoUrl #2827

pdehaan opened this issue Feb 11, 2023 · 0 comments
Labels
jira-synced Jira task created for this

Comments

@pdehaan
Copy link
Collaborator

pdehaan commented Feb 11, 2023

Re: https://monitor.firefox.com/hibp/breaches

Ctrl+F for "LogoPath" (via HIBP feed). You should get around 655 results (one per breach).
Ctrl+F for "LogoUrl" (which we inject). Each time you refresh you seem to get a different count.

I think we're injecting it here, but not sure why it only seems to inject in some and not others.

Ctrl+F counts [for "LogoUrl"] between refreshes:

  • 41 matches
  • 45 matches
  • 3 matches
  • 31 matches
  • 225 matches

It was breaking my https://github.com/pdehaan/blurts-schema/ linter, so I had to manually inject the CDN urls myself since it didn't like the field intermittently appearing in records.

@EMMLynch EMMLynch added the jira-synced Jira task created for this label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-synced Jira task created for this
Projects
None yet
Development

No branches or pull requests

2 participants