Skip to content

Commit

Permalink
Bug 1607877 [wpt PR 21093] - Update cookie WPT expectations to suppor…
Browse files Browse the repository at this point in the history
…t nameless cookies., a=testonly

Automatic update from web-platform-tests
Update cookie WPT expectations to support nameless cookies.

Based on the discussion in [1], we should change the spec to support
nameless cookies parsed from headers like `Set-Cookie: foo`. This patch
updates the WPT expectations accordingly.

[1]: httpwg/http-extensions#159

Bug: 1037996
Change-Id: Iefabea524377857d524c74457153347a107401ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982551
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729807}

--

wpt-commits: ceb4b92d4fea4a2559ecb02ab3c6c8c06134dd75
wpt-pr: 21093
  • Loading branch information
mikewest authored and moz-wptsync-bot committed Jan 20, 2020
1 parent c3f15b9 commit 49c7ea6
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 11 deletions.
20 changes: 10 additions & 10 deletions testing/web-platform/tests/cookies/http-state/general-tests.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ <h3>Test Results</h3>
{file: "0001", name: "Set cookie."},
{file: "0002", name: "Set cookie with future expiration."},
{file: "0003", name: "Set expired cookie along with valid cookie."},
{file: "0004", name: "Ignore cookie without key."},
{file: "0004", name: "Set nameless cookie."},
{file: "0005", name: "Set cookie with age."},
{file: "0006", name: "Set no cookie with max-age=0."},
{file: "0007", name: "Set cookie with version=1."},
Expand All @@ -41,15 +41,15 @@ <h3>Test Results</h3>
{file: "0017", name: "Keep order if comma-separated."},
{file: "0018", name: "Ignore keys after semicolon."},
{file: "0019", name: "Ignore attributes after semicolon."},
{file: "0020", name: "Ignore cookies without key and value."},
{file: "0021", name: "Ignore cookie without key in all 'Set-Cookie'."},
{file: "0022", name: "Set cookie without value in all 'Set-Cookie'."},
{file: "0023", name: "Ignore cookies without '=' in all 'Set-Cookie'."},
{file: "0024", name: "Ignore malformed cookies in all 'Set-Cookie'."},
{file: "0025", name: "Ignore cookies with ';' in all 'Set-Cookie'."},
{file: "0026", name: "Ignore malformed cookies in all 'Set-Cookie' v2."},
{file: "0027", name: "Ignore malformed cookies in all 'Set-Cookie' v3."},
{file: "0028", name: "Ignore malformed cookies in all 'Set-Cookie' v4."},
{file: "0020", name: "Ignore `Set-Cookie: =`."},
{file: "0021", name: "Set nameless cookie, given `Set-Cookie: =x`"},
{file: "0022", name: "Set valueless cookie, given `Set-Cookie: x=`"},
{file: "0023", name: "Ignore empty cookie string."},
{file: "0024", name: "Ignore `Set-Cookie: =` with other `Set-Cookie` headers."},
{file: "0025", name: "Ignore name- and value-less `Set-Cookie: ; bar`."},
{file: "0026", name: "Ignore name- and value-less `Set-Cookie: `."},
{file: "0027", name: "Overwrite nameless cookie."},
{file: "0028", name: "Ignore name- and value-less `Set-Cookie: \t"},
];

for (const i in TEST_CASES) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: foo
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Cookie: a=b; c=d
Cookie: a=b; x; c=d
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: foo
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: foo
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: foo
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: foo
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: bar
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: foo

0 comments on commit 49c7ea6

Please sign in to comment.