From 77fe338b4cd7ce98139bfd81a494ebe629da6231 Mon Sep 17 00:00:00 2001
From: Travis Long <tlong@mozilla.com>
Date: Thu, 25 Apr 2024 07:40:23 -0500
Subject: [PATCH] Bug 1892726 - Update Server Knobs configuration snippets
 (#2197)

* Bug 1892726 - Update Server Knobs configuration snippets

With the recent additions to Glean v60.0.0, the configuration snippets
needed some updates to match the current configuration schema.

* Bug 1892726 - Part 2: Add configuration snippets for pings

This adds Server Knobs configuration snippets to the Ping detail page.
---
 src/pages/MetricDetail.svelte |  2 +-
 src/pages/PingDetail.svelte   | 36 +++++++++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+), 1 deletion(-)

diff --git a/src/pages/MetricDetail.svelte b/src/pages/MetricDetail.svelte
index 81b7d5d9c..c18e6fe47 100644
--- a/src/pages/MetricDetail.svelte
+++ b/src/pages/MetricDetail.svelte
@@ -316,7 +316,7 @@
       </td>
       <td>
         <CopyButton
-          textToCopy="{'{\n  "gleanMetricConfiguration": {\n    "'}{metric.name}{'": true\n  }\n}'}"
+          textToCopy="{'{\n  "gleanMetricConfiguration": {\n    "metrics_enabled": {\n      "'}{metric.name}{'": true\n    }\n  }\n}'}"
           type="MetricDetail.MetricSampling.CopySamplingConfigurationSnippet"
         />
       </td>
diff --git a/src/pages/PingDetail.svelte b/src/pages/PingDetail.svelte
index b771689aa..113c3c664 100644
--- a/src/pages/PingDetail.svelte
+++ b/src/pages/PingDetail.svelte
@@ -10,6 +10,7 @@
   import VariantSelector from "../components/VariantSelector.svelte";
   import AuthenticatedLink from "../components/AuthenticatedLink.svelte";
   import Commentary from "../components/Commentary.svelte";
+  import CopyButton from "../components/CopyButton.svelte";
   import HelpHoverable from "../components/HelpHoverable.svelte";
   import ItemList from "../components/ItemList.svelte";
   import Label from "../components/Label.svelte";
@@ -88,6 +89,41 @@
   />
   <Commentary item={ping} itemType={"ping"} />
 
+  <SubHeading
+    title={"Server Knobs Configuration"}
+    helpText={"Information about Server Knobs configuration for this ping."}
+  />
+  <table>
+    <col />
+    <col />
+    <col />
+    <tr>
+      <td>
+        Sampling Configuration Snippet
+        <HelpHoverable
+          content={"Click the button to copy a configuration snippet for use in Mozilla Experimenter configuration"}
+          link={"https://mozilla.github.io/glean/book/user/pings/data-control-plane/experimenter-configuration.html"}
+        />
+      </td>
+      <td>
+        Click the button to copy a snippet for use in a
+        <a
+          href="https://mozilla.github.io/glean/book/user/pings/data-control-plane/experimenter-configuration.html"
+          data-glean-label="Mozilla Experimenter configuration"
+          data-glean-type="PingDetail.PingSampling.MozillaExperimenterConfigurationURL"
+        >
+          Mozilla Experimenter configuration.
+        </a>
+      </td>
+      <td>
+        <CopyButton
+          textToCopy="{'{\n  "gleanMetricConfiguration": {\n    "pings_enabled": {\n      "'}{ping.name}{'": true\n    }\n  }\n}'}"
+          type="PingDetail.PingSampling.CopySamplingConfigurationSnippet"
+        />
+      </td>
+    </tr>
+  </table>
+
   <SubHeading
     title={"Access"}
     helpText={"Ways to access this metric in Mozilla's data warehouse."}