Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty dependency #1879

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Allow empty dependency #1879

merged 1 commit into from
Aug 31, 2023

Conversation

Iinh
Copy link
Contributor

@Iinh Iinh commented Aug 30, 2023 •
edited
Loading

Allow empty dependency field, since probe-scraper also allows it, as such a case is needed with e.g. accounts-backend.

Screenshot 2023-08-31 at 12 44 52 PM

Pull Request checklist

  • The pull request has a descriptive title (and a reference to an issue it
    fixes, if applicable)
  • All tests and linter checks are passing
  • The pull request is free of merge conflicts

@Iinh Iinh force-pushed the allow-empty-dependencies branch from 87becb5 to 8864088 Compare August 31, 2023 10:40
@Iinh Iinh marked this pull request as ready for review August 31, 2023 10:45
@Iinh Iinh requested a review from akkomar August 31, 2023 10:45
@Iinh
Copy link
Contributor Author

Iinh commented Aug 31, 2023

@akkomar does the deploy preview for accounts backend look like what you're expecting?

@Iinh Iinh mentioned this pull request Aug 31, 2023
Merged
3 tasks
@akkomar
Copy link
Contributor

akkomar commented Aug 31, 2023

@akkomar does the deploy preview for accounts backend look like what you're expecting?

Yes, thank you!

@Iinh Iinh merged commit 4b97fed into main Aug 31, 2023
5 checks passed
@Iinh Iinh deleted the allow-empty-dependencies branch August 31, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akkomar akkomar akkomar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iinh @akkomar