Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci full] Bump macOS SDK to 10.12 (Sierra) #1550

Merged
merged 2 commits into from
Mar 16, 2021
Merged

[ci full] Bump macOS SDK to 10.12 (Sierra) #1550

merged 2 commits into from
Mar 16, 2021

Conversation

badboy
Copy link
Member

@badboy badboy commented Mar 15, 2021

We now use clock_gettime_nsec_np, which was only introduced in 10.12
(which was released in 2016).
This effectively drops support for 10.11 for Android builds.

We now use `clock_gettime_nsec_np`, which was only introduced in 10.12
(which was released in 2016).
This effectively drops support for 10.11 for Android builds.
@auto-assign auto-assign bot requested a review from Dexterp37 March 15, 2021 14:48
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with Ci happy!

@badboy badboy force-pushed the fix-darwin-build branch 3 times, most recently from df9b1d7 to 23ca001 Compare March 16, 2021 12:15
clang and cctools selected from the following treeherder run:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=11810f926917ae7e79b7fa156239b2cab7b0327c

This was picked from checking what artifacts another cross-compile build
on Treeherder picked.

This contains clang 11 and corresponding cctools.
This supports both x86_64 and aarch64 darwin. We only need the former
for now (but might use the latter eventually).

It's not clear how stable these URLs are long-term, but we'll work on
getting them into tooltool (or make sure we cache them in the Docker
container instead of installing at runtime)
@badboy badboy force-pushed the fix-darwin-build branch from 23ca001 to 54591ba Compare March 16, 2021 13:36
@badboy badboy merged commit 29d383e into main Mar 16, 2021
@badboy badboy deleted the fix-darwin-build branch March 16, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants