-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1811857, bug 1811888 - Fully remove support for the old events API #2346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems worthy of a changelog entry noting the change from "deprecated" -> "removed", but other than that LGTM!
Way ahead of you: https://github.com/mozilla/glean/blob/main/CHANGELOG.md#v5200-2022-12-13 |
f3c7b2f
to
67029d1
Compare
67029d1
to
53a5d12
Compare
Note that all other changes except the glean_parser update itself aren't visible to users so I didn't put them in the changelog |
53a5d12
to
c08ca0f
Compare
Codecov ReportBase: 29.41% // Head: 29.41% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
=======================================
Coverage 29.41% 29.41%
=======================================
Files 1 1
Lines 34 34
=======================================
Hits 10 10
Misses 24 24 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
c08ca0f
to
2484e5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me!
Will require a glean_parser change.