Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1932322 - Implement the new collection-enabled API #3006

Merged
merged 18 commits into from
Nov 28, 2024
Merged

Bug 1932322 - Implement the new collection-enabled API #3006

merged 18 commits into from
Nov 28, 2024

Commits on Nov 27, 2024

  1. Refactoring: Define utility test function globally

    @badboy
    badboy committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a1a04ad View commit details
    Browse the repository at this point in the history

  2. Check if a ping is enabled before recording a metric for it

    @badboy
    badboy committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e56b685 View commit details
    Browse the repository at this point in the history

  3. Add the new set_collection_enabled API 

    This effectively deprecates `set_upload_enabled`.
    @badboy
    badboy committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5dfda6b View commit details
    Browse the repository at this point in the history

  4. Track whether a ping follows collection_enabled

    @badboy
    badboy committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ed3bda3 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Upgrade to glean_parser 16.1.0

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d7f33ea View commit details
    Browse the repository at this point in the history

  2. Add new follows_collection_enabled parameter to all code

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3767996 View commit details
    Browse the repository at this point in the history

  3. Add a new API to set pings enabled/disabled

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    e5f2d54 View commit details
    Browse the repository at this point in the history

  4. Clear internal storage and storage for all known pings and all lifetimes

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    a28ced6 View commit details
    Browse the repository at this point in the history

  5. Rust sample: use new enable API for testing purposes

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    13d6279 View commit details
    Browse the repository at this point in the history

  6. Clear data when ping gets explicitly disabled

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    db3e8f3 View commit details
    Browse the repository at this point in the history

  7. Fix up Kotlin/Swift tests under the new ping behavior 

    No data is recorded for unknown or disabled pings.
    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    2eca699 View commit details
    Browse the repository at this point in the history

  8. Test the new behavior for enabled pings

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b3deb1f View commit details
    Browse the repository at this point in the history

  9. Only delete queued pings that are disabled

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    74e34a0 View commit details
    Browse the repository at this point in the history

  10. Clean out pending pings when they get disabled

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    c65417c View commit details
    Browse the repository at this point in the history

  11. Don't attempt to increase sequence number for disabled ping

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    09126f5 View commit details
    Browse the repository at this point in the history

  12. Try clearing metrics out again once we know about more pings

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    c22b13c View commit details
    Browse the repository at this point in the history

  13. New test to ensure pending pings are removed before init finishes

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    6a2cb13 View commit details
    Browse the repository at this point in the history

  14. Changelog entry for the new collection-enabled mode

    @badboy
    badboy committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    38da568 View commit details
    Browse the repository at this point in the history