Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1932322 - Support follows_collection_enabled for pings #776

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 20, 2024

Should get some tests.
Also docs.

@badboy badboy marked this pull request as ready for review November 22, 2024 14:04
@badboy badboy requested a review from a team as a code owner November 22, 2024 14:04
@badboy badboy requested review from travis79 and removed request for a team November 22, 2024 14:04
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an empty file tests/test_cli.py, but other than that this looks good to me.

@badboy
Copy link
Member Author

badboy commented Nov 22, 2024

There's an empty file tests/test_cli.py, but other than that this looks good to me.

It's not empty 🙈 (thanks github). It had the executable bit and I figured I remove it while I see it (it is its own commit).

@badboy badboy merged commit 8382608 into main Nov 25, 2024
8 checks passed
@badboy badboy deleted the follows-collection-enabled branch November 25, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants