-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm scripts don't build correctly on windows #226
Comments
I don't really know what that is, can't you use a MINGW based setup like git bash instead? Is the build script the only thing that is broken? |
From what I understand shx just allows you to write cross-platform shell scripts. For example, here's one of the current build scripts:
This script works fine in
Installing shx and then using this script will build correctly on both And yes building the unmodified version on MINGW should work just fine. This is just a bit less complicated for a windows user. |
I use Windows as my default (granted this is a recent change), I wouldn't ever touch cmd where possible. I'm worried this small change will lead to us maintaining a build that very few people will use and will be untested. I would rather provide windows users a docker setup or guide on using mingw than maintaining another code branch. I'm happy to leave this open for other peoples views though, to see if there is enough interest. |
Would be nice if you provided a guide... |
The current scripts for the
npm run build
command userm
andcp
which don't exist incmd.exe
. I've been able to make the build work by utilizing shx. I could make a pull request if you guys don't mind taking a dependency on shx.The text was updated successfully, but these errors were encountered: