Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert http3-server to use Tokio instead of mio #530

Closed
agrover opened this issue Apr 8, 2020 · 3 comments
Closed

Convert http3-server to use Tokio instead of mio #530

agrover opened this issue Apr 8, 2020 · 3 comments
Labels
nice-to-have This is not essential. p3 Backlog
Milestone

Comments

@agrover
Copy link
Contributor

agrover commented Apr 8, 2020

Could be cool, and possibly interesting to see how Neqo worked with an async event model. It already kind of does so this might actually be a good fit.

@agrover agrover added the enhancement New feature or request label Apr 8, 2020
@agrover agrover added this to the Future milestone Apr 8, 2020
@ddragana ddragana added nice-to-have This is not essential. and removed enhancement New feature or request labels Oct 5, 2021
@ddragana ddragana added the p3 Backlog label Nov 24, 2021
@xpepermint
Copy link

Actually, it would be great to support arbitrary async runtime.

@larseggert
Copy link
Collaborator

CC @mxinden

@mxinden
Copy link
Collaborator

mxinden commented Feb 6, 2024

I am not sure what http3-server refers to nowadays. #1581 and #1612 move neqo-server and neqo-client to tokio.

While I believe asynchronicity is a helpful tool, I do very much agree with the argument that it adds complexity and that it is infectious to a codebase (e.g. read "what color is your function"). Thus I suggest driving I/O in an asynchronous fashion, but keeping the core of neqo (i.e. neqo-common, neqo-transport, neqo-http3, neqo-crypto) synchronous.

With the two pull requests and the above argumentation, I believe this can be closed. Agreed @larseggert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice-to-have This is not essential. p3 Backlog
Projects
Status: Closed
Development

No branches or pull requests

5 participants