feat(bin/client): use BufWriter when writing to file

[mxinden]

neqo-client has the option to write a response to file.

With this commit, File is wrapped in a 64KB BufWriter to increase I/O batch size and thus improve performance.

Replaces #1752 (see #1752 (comment)).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (ef5caeb) to head (08bf642).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1756   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         119      119           
  Lines       37253    37253           
=======================================
  Hits        34637    34637           
  Misses       2616     2616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark results

Performance differences relative to ef5caeb.

• coalesce_acked_from_zero 1+1 entries
  time: [193.10 ns 193.57 ns 194.07 ns]
  change: [-0.2210% +0.4070% +0.9860%] (p = 0.21 > 0.05)
  No change in performance detected.

• coalesce_acked_from_zero 3+1 entries
  time: [235.66 ns 236.31 ns 237.04 ns]
  change: [-0.4942% -0.0134% +0.4438%] (p = 0.96 > 0.05)
  No change in performance detected.

• coalesce_acked_from_zero 10+1 entries
  time: [234.69 ns 235.24 ns 235.94 ns]
  change: [-1.0880% -0.6177% -0.1786%] (p = 0.01 < 0.05)
  Change within noise threshold.

• coalesce_acked_from_zero 1000+1 entries
  time: [213.99 ns 214.21 ns 214.47 ns]
  change: [-10.211% -3.5631% +0.5650%] (p = 0.37 > 0.05)
  No change in performance detected.

• RxStreamOrderer::inbound_frame()
  time: [120.57 ms 120.73 ms 120.96 ms]
  change: [+0.3136% +0.4616% +0.6614%] (p = 0.00 < 0.05)
  Change within noise threshold.

• transfer/Run multiple transfers with varying seeds
  time: [118.33 ms 118.63 ms 118.93 ms]
  thrpt: [33.634 MiB/s 33.718 MiB/s 33.802 MiB/s]
  change:
  time: [-0.0460% +0.2878% +0.6252%] (p = 0.09 > 0.05)
  thrpt: [-0.6213% -0.2870% +0.0460%]
  No change in performance detected.

• transfer/Run multiple transfers with the same seed
  time: [118.74 ms 118.92 ms 119.12 ms]
  thrpt: [33.580 MiB/s 33.635 MiB/s 33.687 MiB/s]
  change:
  time: [-0.0088% +0.2022% +0.4126%] (p = 0.07 > 0.05)
  thrpt: [-0.4109% -0.2018% +0.0088%]
  No change in performance detected.

⬇️ Download logs