Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(server): simplify :method POST check #1787

Merged
merged 1 commit into from
Apr 2, 2024
Merged

refactor(server): simplify :method POST check #1787

merged 1 commit into from
Apr 2, 2024

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Apr 2, 2024

No description provided.

@larseggert larseggert added this pull request to the merge queue Apr 2, 2024
Merged via the queue into mozilla:main with commit 0751429 Apr 2, 2024
13 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Benchmark results

Performance differences relative to 27a7250.

  • drain a timer quickly time: [353.84 ns 361.27 ns 368.09 ns]
    change: [-1.1427% +0.9383% +2.8603%] (p = 0.35 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1+1 entries
    time: [195.49 ns 195.98 ns 196.48 ns]
    change: [-0.4131% -0.0486% +0.2648%] (p = 0.79 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [234.74 ns 235.37 ns 236.01 ns]
    change: [-0.4850% -0.2014% +0.0629%] (p = 0.17 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [233.65 ns 234.19 ns 234.87 ns]
    change: [-0.6283% -0.0267% +0.6783%] (p = 0.94 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [216.61 ns 216.76 ns 216.92 ns]
    change: [-0.9989% -0.3100% +0.3539%] (p = 0.38 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [118.74 ms 118.79 ms 118.85 ms]
    change: [-0.0178% +0.0580% +0.1340%] (p = 0.13 > 0.05)
    No change in performance detected.

  • transfer/Run multiple transfers with varying seeds
    time: [117.57 ms 117.85 ms 118.11 ms]
    thrpt: [33.866 MiB/s 33.943 MiB/s 34.021 MiB/s]
    change:
    time: [-4.3137% -4.0102% -3.6979%] (p = 0.00 < 0.05)
    thrpt: [+3.8399% +4.1777% +4.5082%]
    💚 Performance has improved.

  • transfer/Run multiple transfers with the same seed
    time: [118.81 ms 118.98 ms 119.15 ms]
    thrpt: [33.571 MiB/s 33.619 MiB/s 33.667 MiB/s]
    change:
    time: [-3.8272% -3.6432% -3.4602%] (p = 0.00 < 0.05)
    thrpt: [+3.5842% +3.7809% +3.9795%]
    💚 Performance has improved.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.1017 s 1.1088 s 1.1168 s]
    thrpt: [89.539 MiB/s 90.189 MiB/s 90.772 MiB/s]
    change:
    time: [-2.7162% -1.2391% +0.1297%] (p = 0.13 > 0.05)
    thrpt: [-0.1296% +1.2546% +2.7921%]
    No change in performance detected.

  • 1-conn/10_000-1b-seq-resp (aka. RPS)/client
    time: [424.22 ms 426.28 ms 428.38 ms]
    thrpt: [23.344 Kelem/s 23.459 Kelem/s 23.573 Kelem/s]
    change:
    time: [-1.2093% -0.4815% +0.2255%] (p = 0.17 > 0.05)
    thrpt: [-0.2250% +0.4838% +1.2241%]
    No change in performance detected.

  • 100-seq-conn/1-1b-resp (aka. HPS)/client
    time: [3.3657 s 3.3687 s 3.3718 s]
    thrpt: [29.658 elem/s 29.685 elem/s 29.712 elem/s]
    change:
    time: [-0.2089% -0.0832% +0.0474%] (p = 0.20 > 0.05)
    thrpt: [-0.0474% +0.0832% +0.2094%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 656.7 ± 300.3 378.6 1286.3 1.00
neqo msquic reno on 2074.4 ± 235.0 1866.8 2556.6 1.00
neqo msquic reno 2122.2 ± 177.7 1917.8 2485.9 1.00
neqo msquic cubic on 2154.7 ± 290.9 1901.1 2643.1 1.00
neqo msquic cubic 2035.7 ± 253.2 1826.6 2567.7 1.00
msquic neqo reno on 4401.2 ± 171.0 4103.3 4638.5 1.00
msquic neqo reno 4433.6 ± 309.6 4163.4 5223.1 1.00
msquic neqo cubic on 4457.7 ± 182.3 4230.7 4765.9 1.00
msquic neqo cubic 4497.8 ± 259.4 4157.5 4915.2 1.00
neqo neqo reno on 3776.4 ± 310.6 3436.4 4342.3 1.00
neqo neqo reno 3854.7 ± 296.1 3562.8 4544.4 1.00
neqo neqo cubic on 4504.3 ± 295.9 4041.1 5043.9 1.00
neqo neqo cubic 4568.5 ± 381.6 4174.6 5359.4 1.00

⬇️ Download logs

mxinden added a commit to mxinden/neqo that referenced this pull request May 4, 2024
@mxinden
refactor: merge mozilla-central http3 server into neqo-bin
98b969e 
There are two server implementations based on neqo:

1. https://github.com/mozilla/neqo/tree/main/neqo-bin/src/server
  - http3 and http09 implementation
  - used for manual testing and QUIC Interop

2. https://searchfox.org/mozilla-central/source/netwerk/test/http3server/src/main.rs
  - used to test Firefox

I assume one was once an exact copy of the other. Both implement their own I/O,
event loop, ... Since then, the two implementations diverged significantly.
Especially (1) saw a lot of improvements in recent months:

- mozilla#1564
- mozilla#1569
- mozilla#1578
- mozilla#1581
- mozilla#1604
- mozilla#1612
- mozilla#1676
- mozilla#1692
- mozilla#1707
- mozilla#1708
- mozilla#1727
- mozilla#1753
- mozilla#1756
- mozilla#1766
- mozilla#1772
- mozilla#1786
- mozilla#1787
- mozilla#1788
- mozilla#1794
- mozilla#1806
- mozilla#1808
- mozilla#1848
- mozilla#1866

At this point, bugs in (2) are hard to fix, see e.g.
mozilla#1801.

This commit merges (2) into (1), thus removing all duplicate logic and
having (2) benefit from all the recent improvements to (1).
@mxinden mxinden mentioned this pull request May 4, 2024
Merged
KershawChang pushed a commit to KershawChang/neqo that referenced this pull request May 7, 2024
@mxinden @KershawChang
refactor: merge mozilla-central http3 server into neqo-bin
d1900d6 
There are two server implementations based on neqo:

1. https://github.com/mozilla/neqo/tree/main/neqo-bin/src/server
  - http3 and http09 implementation
  - used for manual testing and QUIC Interop

2. https://searchfox.org/mozilla-central/source/netwerk/test/http3server/src/main.rs
  - used to test Firefox

I assume one was once an exact copy of the other. Both implement their own I/O,
event loop, ... Since then, the two implementations diverged significantly.
Especially (1) saw a lot of improvements in recent months:

- mozilla#1564
- mozilla#1569
- mozilla#1578
- mozilla#1581
- mozilla#1604
- mozilla#1612
- mozilla#1676
- mozilla#1692
- mozilla#1707
- mozilla#1708
- mozilla#1727
- mozilla#1753
- mozilla#1756
- mozilla#1766
- mozilla#1772
- mozilla#1786
- mozilla#1787
- mozilla#1788
- mozilla#1794
- mozilla#1806
- mozilla#1808
- mozilla#1848
- mozilla#1866

At this point, bugs in (2) are hard to fix, see e.g.
mozilla#1801.

This commit merges (2) into (1), thus removing all duplicate logic and
having (2) benefit from all the recent improvements to (1).
github-merge-queue bot pushed a commit that referenced this pull request May 8, 2024
@mxinden
refactor: enable mozilla-central http3server to use neqo-bin (#1878)
b8ae981 
* refactor(bin): introduce server/http3.rs and server/http09.rs

The QUIC Interop Runner requires an http3 and http09 implementation for both
client and server. The client code is already structured into an http3 and an
http09 implementation since #1727.

This commit does the same for the server side, i.e. splits the http3 and http09
implementation into separate Rust modules.

* refactor: merge mozilla-central http3 server into neqo-bin

There are two server implementations based on neqo:

1. https://github.com/mozilla/neqo/tree/main/neqo-bin/src/server
  - http3 and http09 implementation
  - used for manual testing and QUIC Interop

2. https://searchfox.org/mozilla-central/source/netwerk/test/http3server/src/main.rs
  - used to test Firefox

I assume one was once an exact copy of the other. Both implement their own I/O,
event loop, ... Since then, the two implementations diverged significantly.
Especially (1) saw a lot of improvements in recent months:

- #1564
- #1569
- #1578
- #1581
- #1604
- #1612
- #1676
- #1692
- #1707
- #1708
- #1727
- #1753
- #1756
- #1766
- #1772
- #1786
- #1787
- #1788
- #1794
- #1806
- #1808
- #1848
- #1866

At this point, bugs in (2) are hard to fix, see e.g.
#1801.

This commit merges (2) into (1), thus removing all duplicate logic and
having (2) benefit from all the recent improvements to (1).

* Move firefox.rs to mozilla-central

* Reduce HttpServer trait functions

* Extract constructor

* Remove unused deps

* Remove clap color feature

Nice to have. Adds multiple dependencies. Hard to justify for mozilla-central.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larseggert larseggert larseggert approved these changes

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @larseggert