Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests on Android emulator #2058

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Aug 19, 2024

Pendant to quinn-rs/quinn#1950.

Fixes #2028.

@mxinden
Copy link
Collaborator Author

mxinden commented Aug 19, 2024

Failing with:

android-actions/setup-android@v2 and reactivecircus/android-emulator-runner@v2 are not allowed to be used in mozilla/neqo.

@larseggert where do I find Mozilla's list of allowed GitHub actions?

@larseggert
Copy link
Collaborator

https://github.com/mozilla/neqo/settings/actions under "General" has the list. Let me know if that is not visible to you.

Copy link

github-actions bot commented Aug 19, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@mxinden mxinden force-pushed the ci-android branch 2 times, most recently from d14254b to 1edbba7 Compare August 19, 2024 14:23
Copy link

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

@larseggert
Copy link
Collaborator

@mxinden did you ask for the actions to be allowlisted? Should I?

@mxinden
Copy link
Collaborator Author

mxinden commented Nov 15, 2024

I have not gotten to it, sorry. Help appreciated. I assume reactivecircus/android-emulator-runner is the most important one, i.e. most difficult to write ourselves.

@larseggert
Copy link
Collaborator

@mxinden these actions should now be available: https://bugzilla.mozilla.org/show_bug.cgi?id=1931529

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (2fe2922) to head (6f9b8d9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2058   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files         112      112           
  Lines       36569    36569           
=======================================
  Hits        34879    34879           
  Misses       1690     1690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mxinden
Copy link
Collaborator Author

mxinden commented Nov 19, 2024

Cross-compilation of NSS for Android on Linux is failing. I will look into this.

@larseggert
Copy link
Collaborator

It's probably because it is grabbing the precompiled Linux build for NSS from the action cache. We need to differentiate between Linux and Android when building/caching NSS.

@larseggert
Copy link
Collaborator

We need to discuss with the NSS team how they build for Android. I have the suspicion that there are again no instructions, and just the way that the Firefox build does it is working. Topic for Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: test on Android
2 participants