Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stop the PMTUD search at the interface MTU #2135

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/firefox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,21 @@ jobs:

- name: Plumb in Neqo
run: |
# Get qlog version used by neqo
# Get qlog and mtu version used by neqo
cargo generate-lockfile
QLOG_VERSION=$(cargo pkgid qlog | cut -d@ -f2)
MTU_VERSION=$(cargo pkgid mtu | cut -d@ -f2)
rm Cargo.lock
cd mozilla-unified
{
echo '[[audits.qlog]]'
echo 'who = "CI"'
echo 'criteria = "safe-to-deploy"'
echo "version = \"$QLOG_VERSION\""
echo '[[audits.mtu]]'
echo 'who = "CI"'
echo 'criteria = "safe-to-deploy"'
echo "version = \"$MTU_VERSION\""
} >> supply-chain/audits.toml
sed -i'' -e "s/qlog =.*/qlog = \"$QLOG_VERSION\"/" netwerk/socket/neqo_glue/Cargo.toml
{
Expand All @@ -107,6 +112,18 @@ jobs:
echo 'neqo-qpack = { path = "../neqo-qpack" }'
echo 'neqo-crypto = { path = "../neqo-crypto" }'
} >> Cargo.toml
{
echo '[[trusted.windows-bindgen]]'
echo 'criteria = "safe-to-deploy"'
echo 'user-id = 64539 # Kenny Kerr (kennykerr)'
echo 'start = "2021-11-15"'
echo 'end = "2024-09-12"'
echo '[[trusted.windows-metadata]]'
echo 'criteria = "safe-to-deploy"'
echo 'user-id = 64539 # Kenny Kerr (kennykerr)'
echo 'start = "2021-11-15"'
echo 'end = "2024-09-12"'
} >> supply-chain/audits.toml
cargo update neqo-http3 neqo-transport neqo-common neqo-qpack neqo-crypto
./mach vendor rust --ignore-modified

Expand Down
84 changes: 82 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions neqo-transport/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ indexmap = { version = "2.2", default-features = false } # See https://github.co
log = { workspace = true }
neqo-common = { path = "../neqo-common" }
neqo-crypto = { path = "../neqo-crypto" }
mtu = { version = "0.2.3", default-features = false } # neqo is only user currently, can bump freely
qlog = { workspace = true }
smallvec = { version = "1.13", default-features = false }
static_assertions = { workspace = true }
Expand All @@ -39,6 +40,7 @@ build-fuzzing-corpus = [
"test-fixture/disable-random",
]
disable-encryption = ["neqo-crypto/disable-encryption"]
gecko = ["mtu/gecko"]

[lib]
# See https://github.com/bheisler/criterion.rs/blob/master/book/src/faq.md#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options
Expand Down
Loading
Loading