ci: Enable MC/DC coverage #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en.wikipedia.org/wiki/Code_coverage#Modified_condition/decision_coverage MC/DC is finding some partially covered lines, so coverage drops. This is expected.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
mxinden
approved these changes
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
- Coverage 95.40% 93.41% -1.99%
==========================================
Files 113 113
Lines 36721 36743 +22
Branches 0 1632 +1632
==========================================
- Hits 35032 34325 -707
Misses 1689 1689
- Partials 0 729 +729 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to a1b9364. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to a1b9364. decode 4096 bytes, mask ff: No change in performance detected. time: [11.850 µs 11.899 µs 11.964 µs]
change: [-0.3611% +0.1804% +0.7242%] (p = 0.53 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0933 ms 3.1005 ms 3.1094 ms]
change: [-0.7806% -0.3230% +0.0892%] (p = 0.15 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.785 µs 19.830 µs 19.883 µs]
change: [-0.0417% +0.4901% +1.2036%] (p = 0.11 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1674 ms 5.1801 ms 5.1934 ms]
change: [-0.3607% -0.0071% +0.3427%] (p = 0.94 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.9101 µs 6.9437 µs 6.9839 µs]
change: [-0.1015% +0.3997% +0.9594%] (p = 0.15 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7627 ms 1.7696 ms 1.7778 ms]
change: [-0.3577% +0.1794% +0.7349%] (p = 0.52 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [104.86 ns 105.24 ns 105.62 ns]
change: [-0.4447% -0.0195% +0.4176%] (p = 0.93 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [120.33 ns 121.19 ns 122.50 ns]
change: [-0.4940% +0.0207% +0.6251%] (p = 0.95 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [119.82 ns 120.07 ns 120.40 ns]
change: [-0.7413% -0.2593% +0.1567%] (p = 0.29 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [100.89 ns 101.04 ns 101.22 ns]
change: [-0.5602% +0.3030% +1.2041%] (p = 0.51 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [110.86 ms 110.93 ms 110.99 ms]
change: [-0.2844% -0.2073% -0.1337%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.5272 µs 5.6806 µs 5.8343 µs]
change: [-3.0375% +5.0037% +17.897%] (p = 0.58 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [28.855 ms 29.447 ms 30.032 ms]
change: [-1.3773% +1.3515% +4.1141%] (p = 0.33 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [30.679 ms 31.198 ms 31.703 ms]
change: [-4.4035% -2.0177% +0.1401%] (p = 0.08 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [24.810 ms 25.302 ms 25.791 ms]
change: [-2.3234% +0.7452% +3.7865%] (p = 0.63 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [27.103 ms 27.880 ms 28.652 ms]
change: [-4.6475% -0.7642% +3.4238%] (p = 0.71 > 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [892.94 ms 903.38 ms 913.86 ms]
thrpt: [109.43 MiB/s 110.70 MiB/s 111.99 MiB/s]
change:
time: [-0.9790% +0.5823% +2.2308%] (p = 0.47 > 0.05)
thrpt: [-2.1822% -0.5789% +0.9886%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [315.39 ms 318.47 ms 321.62 ms]
thrpt: [31.092 Kelem/s 31.400 Kelem/s 31.707 Kelem/s]
change:
time: [-0.6911% +0.6283% +2.0148%] (p = 0.38 > 0.05)
thrpt: [-1.9750% -0.6244% +0.6959%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold. time: [33.692 ms 33.882 ms 34.091 ms]
thrpt: [29.334 elem/s 29.514 elem/s 29.681 elem/s]
change:
time: [+0.0561% +0.8559% +1.6544%] (p = 0.04 < 0.05)
thrpt: [-1.6275% -0.8486% -0.0561%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.6234 s 1.6404 s 1.6576 s]
thrpt: [60.329 MiB/s 60.959 MiB/s 61.601 MiB/s]
change:
time: [-4.5466% -3.1425% -1.6568%] (p = 0.00 < 0.05)
thrpt: [+1.6847% +3.2444% +4.7632%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
martinthomson
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.wikipedia.org/wiki/Code_coverage#Modified_condition/decision_coverage
The point of the PR is to make it easier to spot lines with partial coverage, which AFAICT currently show up as green.
MC/DC is finding some partially covered lines, so coverage drops. This is expected.