Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base arg to int filter #1309

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Add base arg to int filter #1309

merged 1 commit into from
Jul 30, 2020

Conversation

ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Jul 27, 2020

Summary

Proposed change:

Add base arg for int filter, to match Jinja2 behaviour.

Closes #1307.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@ogonkov ogonkov changed the title Add int base arg Add base arg to int filter Jul 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #1309 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1309   +/-   ##
=======================================
  Coverage   89.68%   89.69%           
=======================================
  Files          22       22           
  Lines        3045     3046    +1     
=======================================
+ Hits         2731     2732    +1     
  Misses        314      314           
Impacted Files Coverage Δ
nunjucks/src/filters.js 96.25% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c02062...7ef121c. Read the comment docs.

@ogonkov ogonkov marked this pull request as ready for review July 27, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

int filter missing base kwarg
3 participants