Merge pull request #18154 from timvandermeij/integration-test-rect

Introduce a `getRect` utility function for the integration tests
mozilla · May 23, 2024 · 08bf968 · 08bf968
2 parents 0c562f0 + 145d660
commit 08bf968
Show file tree

Hide file tree

Showing 6 changed files with 136 additions and 467 deletions.
diff --git a/test/integration/caret_browsing_spec.mjs b/test/integration/caret_browsing_spec.mjs
@@ -13,7 +13,7 @@
  * limitations under the License.
  */
 
-import { closePages, loadAndWait } from "./test_utils.mjs";
+import { closePages, getRect, loadAndWait } from "./test_utils.mjs";
 
 const waitForSelectionChange = (page, selection) =>
   page.waitForFunction(
@@ -38,13 +38,10 @@ describe("Caret browsing", () => {
     it("must move the caret down and check the selection", async () => {
       await Promise.all(
         pages.map(async ([browserName, page]) => {
-          const spanRect = await page.evaluate(() => {
-            const span = document.querySelector(
-              `.page[data-page-number="1"] > .textLayer > span`
-            );
-            const { x, y, width, height } = span.getBoundingClientRect();
-            return { x, y, width, height };
-          });
+          const spanRect = await getRect(
+            page,
+            `.page[data-page-number="1"] > .textLayer > span`
+          );
           await page.mouse.click(
             spanRect.x + 1,
             spanRect.y + spanRect.height / 2,