Skip to content

Commit

Permalink
Update the GitHub Actions workflows to use the current Node.js LTS ve…
Browse files Browse the repository at this point in the history
…rsion

The active LTS version is now based on Node.js version 20, hence let's update the relevant workflows to use that one instead; see https://en.wikipedia.org/wiki/Node.js#Releases

Given that we still support Node.js version 18, i.e. the maintenance LTS version, in the PDF.js library we'll keep testing both versions in GitHub Actions to prevent regressions.
  • Loading branch information
Snuffleupagus committed Oct 29, 2023
1 parent 355bce2 commit d00c7d5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,20 @@ jobs:
name: Test
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18, lts/*]

steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node.js 18 LTS
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: ${{ matrix.node-version }}

- name: Install Gulp
run: npm install -g gulp-cli
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/publish_website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,20 @@ jobs:
name: Build
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [lts/*]

steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node.js 18 LTS
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: ${{ matrix.node-version }}

- name: Install Gulp
run: npm install -g gulp-cli
Expand Down

0 comments on commit d00c7d5

Please sign in to comment.