Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 release #10181

Closed
brendandahl opened this issue Oct 24, 2018 · 8 comments
Closed

2.0 release #10181

brendandahl opened this issue Oct 24, 2018 · 8 comments
Labels

Comments

@brendandahl
Copy link
Contributor

In our usual release flow we've been moving pre-release to release and generating a new pre-release from master. I was about to generate the new pre-release, but I haven't been following API changes closely lately, so I'm unsure of what the version number should be. Is the current master 2.0 or 2.1 or need to be 3.0?

We could also just remove the current pre-release and make new 2.0 release from master. Then release that.

@Snuffleupagus @timvandermeij

@timvandermeij
Copy link
Contributor

The current pre-release indeed needs to be removed since we fixed some regressions found in it (see the note on https://github.com/mozilla/pdf.js/projects/5). That would mean that we will only end up with a stable release, so no beta release temporarily. Possibly the download page needs to be updated slightly to handle that (i.e., not show the button).

The current master would be version 2.0. From that point on, I think we can create 2.1.

@timvandermeij
Copy link
Contributor

timvandermeij commented Oct 25, 2018

I'll coordinate the stable 2.0 release. Tasks:

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Oct 27, 2018

That would mean that we will only end up with a stable release, so no beta release temporarily. Possibly the download page needs to be updated slightly to handle that (i.e., not show the button).

The simplest solution might be to temporarily just set both version numbers to the same one, to avoid having to alter the page.

@timvandermeij
Copy link
Contributor

Closing since version 2.0 is now stable. I had some trouble pushing the stable version to pdfjs-dist/NPM; this will be handled in a follow-up somewhere next week.

@timvandermeij
Copy link
Contributor

I have updated the project board at https://github.com/mozilla/pdf.js/projects/5. In particular I could use some help with writing a migration guide because I'm not sure if all api-minor/api-major PRs cover all changes that people should know about?

@Snuffleupagus
Copy link
Collaborator

While it looks like the npm version has now been updated, based on https://www.npmjs.com/package/pdfjs-dist, it doesn't look like pdfjs-dist was updated yet, based on https://github.com/mozilla/pdfjs-dist/commits/master.

Ninja-edit: Although based on https://github.com/mozilla/pdfjs-dist/releases, it looks like pdfjs-dist was partially updated; is the master branch of pdfjs-dist no longer intended to be updated (if so, why?), or is there perhaps still some work to do here?

Also, it looks like brendandahl/botio@3f0fe06#diff-c945a46d13b34fcaff544d966cffcabaR448 may accidentally have broken the links back to the main repo, since e.g. https://github.com/mozilla/pdfjs-dist/releases/tag/v2.0.943 no longer contains a click-able link:

PDF.js version 2.0.943 - See mozilla/pdf.js@tags/v2.0.943

For earlier versions of pdfjs-dist, the releases looked e.g. like:

PDF.js version 2.0.489 - See mozilla/pdf.js@7d7bc80

@timvandermeij
Copy link
Contributor

For pdfjs-dist we only make releases and tags; see https://mozilla.logbot.info/pdfjs/20181030#c15543738. I'm not entirely sure why we don't update the master branch anymore, but apparently we don't. Maybe @brendandahl can tell why?

I'll create a note for both points on the project board.

@brendandahl
Copy link
Contributor Author

I was thinking master would only be updated with with each new release. I'm not sure why it didn't update with our last release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants