Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using mozPrintCallback in generic builds #10528

Closed
brendandahl opened this issue Feb 8, 2019 · 2 comments
Closed

Stop using mozPrintCallback in generic builds #10528

brendandahl opened this issue Feb 8, 2019 · 2 comments

Comments

@brendandahl
Copy link
Contributor

Over in https://bugzilla.mozilla.org/show_bug.cgi?id=1524640 the fix is only allowed for the built in pdf.js viewer, so if fonts are cleaned before the callback, printing will break. There's also been a little discussion on moving mozPrintCallback to only be allowed by the internal PDF.js viewer since no other browser implement it nor do they plan to.

@Snuffleupagus
Copy link
Collaborator

The generic printing code, which is found in web/pdf_print_service.js, hasn't been using mozPrintCallback ever since PR #7697 :-)

The only usage of mozPrintCallback is found in https://github.com/mozilla/pdf.js/blob/master/web/firefox_print_service.js, a file which is only bundled into MOZCENTRAL builds:

pdf.js/web/viewer.js

Lines 44 to 47 in 7d24fc3

if (typeof PDFJSDev !== 'undefined' && PDFJSDev.test('FIREFOX || MOZCENTRAL')) {
require('./firefoxcom.js');
require('./firefox_print_service.js');
}

@brendandahl
Copy link
Contributor Author

Hah, missed that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants