Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiling pattern cache may incorrectly cache patterns with same name #13780

Closed
brendandahl opened this issue Jul 22, 2021 · 0 comments · Fixed by #13904
Closed

Tiling pattern cache may incorrectly cache patterns with same name #13780

brendandahl opened this issue Jul 22, 2021 · 0 comments · Fixed by #13904

Comments

@brendandahl
Copy link
Contributor

It's possible for a PDF page to have multiple resource dictionaries which could have patterns (shading or tiling) that have the same names. Our cache currently works off of name, so we could potentially be caching one pattern and retrieving the wrong one if the name is the same, but the resource dictionary has changed.

I'm not aware of any PDFs affected by this issue, but issue6737.pdf has an example of this with radial shadings. There are two patterns P1 and P2 which each have their own resource dictionaries. Each of those resource dictionaries has a pattern named Sh0, but they are different shadings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant