Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFjs default pref values can't be set via policy #16105

Closed
mkaply opened this issue Mar 3, 2023 · 2 comments
Closed

PDFjs default pref values can't be set via policy #16105

mkaply opened this issue Mar 3, 2023 · 2 comments

Comments

@mkaply
Copy link

mkaply commented Mar 3, 2023

Because of the way PDF.js sets default values (async, late in startup), they can't be set by policy.

So if policy tries to override the default value for say cursorToolOnLoad, it doesn't work.

When processing PdfJsDefaultPreferences, there should be a check if the value already exist on the default branch and if so, don't set them.

There's a workaround (user preferences), but it would be better if default could be set.

@Snuffleupagus
Copy link
Collaborator

When processing PdfJsDefaultPreferences, there should be a check if the value already exist on the default branch and if so, don't set them.

The "correct" solution would probably be to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1780609 instead, see PR #15209, however that'd require feedback from someone knowledgeable about the Firefox preference system to move forward.

@mkaply
Copy link
Author

mkaply commented Mar 3, 2023

I'm actually wrong. It was a loading mistake on my end. Policy can set these fine.

I do have to load PdfJsDefaultPreferences explicitly so I know the preference type though.

@mkaply mkaply closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants