Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension is not built correctly when git is missing from PATH #5403

Closed
automatedbugreportingfacility opened this issue Oct 13, 2014 · 1 comment

Comments

@automatedbugreportingfacility

As I was building extensions (Windows 7, "node make firefox") to bisect #5400, I noticed that when "git" is not an environmental variable, a broken extension is generated due to following code in pdf.js and pdf.worker.js:

PDFJS.build = ''git' is not recognized as an internal or external command,
operable program or batch file.
';

With this string fixed, the extension worked alright. Would it be possible to fall back to some valid string for "PDFJS.build" if git is missing from PATH?

@Snuffleupagus
Copy link
Collaborator

Given that the Firefox addon was removed in PR #9566, this issue can probably be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants