node svg example double-encodes element attributes

[Rob--W]

pdf.js/examples/node/domstubs.js

Lines 84 to 87 in 9bed695

	setAttributeNS: function DOMElement_setAttributeNS(NS, name, value) {
	value = value || '';
	value = xmlEncode(value);
	this.attributes[name] = value;

  setAttributeNS: function DOMElement_setAttributeNS(NS, name, value) {
    value = value || '';
    value = xmlEncode(value);
    this.attributes[name] = value;

pdf.js/examples/node/domstubs.js

Line 105 in 9bed695

buf.push(' ' + i + '="' + xmlEncode(this.attributes[i]) + '"');

      buf.push(' ' + i + '="' + xmlEncode(this.attributes[i]) + '"');

One of the two should be removed. Most likely the first one, because getAttributeNS's implementation just returns this.attributes[i], and that should not be encoded.

[yurydelendik]

Can we replace our stubs with jsdom / jsdom-global?

[Rob--W]

I think that it's better to not do that. We use a very limited subset of the DOM, so it is relatively easy to implement and optimize the stubs for our use case; jsdom seems overkill for us. Also, our example currently does not have any external module dependencies, which simplifies testing (though this is a very minor point).