-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluation of support for old Chrome versions #9397
Comments
I have just built the latest version of the PDF.js extension (2.0.288) with
|
Chrome 31 and 32 refuses to load the extension because of manifest.json. The currently published version of PDF.js does already not support Chrome 48 because of the syntax issues, and I haven't seen any complaints. The number of users that use Chrome 48 and lower is 1.09% according to the above statistics. A part of these numbers are likely spoofed UAs or otherwise not real users. So I will submit a patch to re-enable support for Chrome 49, and follow up with ripping out code that was added to support Chrome 48 and older. |
#9409 fixes Chrome 49 support. What remains is cleanup of code to drop Chrome 48- compatibility. |
Nice work! |
The Chrome extension has been designed to support all Chrome versions since the initial release.
We need to evaluate whether there are commonly used versions that we wish to support, and maybe set a
minmum_chrome_version
inmanifest.json
to explicitly drop support for older versions.We can make a data=driven decision since I've been collecting information about browser usage statistics via pdfjs.robwu.nl (https://github.com/Rob--W/pdfjs-telemetry).
In November 2017, I compiled a list of Chrome versions: #8768 (comment)
I looked at the data again for this month (2018, 1 jan - 22 jan):
Windows XP users are stuck at Chrome 49, so that is currently the lower bound of browser versions that I wish to support. There is also a number of users on Chromium 34 (Ubuntu), so if it does not take too much efforts, I'd also like to support them.
The text was updated successfully, but these errors were encountered: