-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that pdfjs-dist is a "nightly" build #9440
Comments
Or we could send npm releases instead. |
npm releases, please! I'd use |
I did some work on this over in mozilla/botio-files-pdfjs#22. One thing I'm not sure how to handle is fixing our current npm setup. I'm thinking I'll retag the 2.0 branch as |
Can't answer for the whole community but in my opinion, the change is very much worth this one-time commotion. |
I think that that is indeed the best solution here. Moreover, if we release the final 2.0 version, it will have a higher version number, so I think (but I might be wrong here since I'm not that fimilar with the inner workings of NPM) that people that pulled a previous release will then automatically be upgraded to the final 2.0 version. |
Oh yeah. We can just tag non-final releases with
So that's pretty sweet IMO. We could also give people from point 1 stuck on 1.x pre-release a hint using npm deprecate by deprecating all 1.x pre-releases with a message like "You're likely unknowingly using unstable PDF.js release. Please downgrade to the newest stable version, 1.9.xxx or upgrade to all-new 2.x version. Upgrade guide here: http://example.com/pdfjsupgradeguide". |
The change for the bots is now merged. @brendandahl Is there anything else that needs to be done for this issue, other than perhaps a bot restart/webhook? |
Where does this sit? I'm really hoping for a webpack 4 compatible release soon. |
It seems like this is done |
Yes, the |
do you have any plan when will you release for 2.0? is there any remaining issues regarding 2.0? https://github.com/mozilla/pdf.js/projects/5 |
@banyan You can use it now: |
@prohtex, it's clearly marked as a pre-release. |
@wojtekmaj Didn't say it wasn't a pre-release. I was told it would be more or less functionally the same as release. Given that is very difficult to find this link, I thought I'd share it. |
Closing since this is done. |
https://github.com/mozilla/pdfjs-dist and https://www.npmjs.com/package/pdfjs-dist does not clearly show that the release is a continuous build. The documentation, sourced from https://github.com/mozilla/pdf.js/blob/a7c35025fed8beb8f9b93688fff40497c7ad2de0/external/dist/README.md should probably be changed to make this more clear. And https://mozilla.github.io/pdf.js/getting_started/ does not clearly state that pdfjs-dist is not the stable release build.
Here is an example of confusion that was caused by this: #9385 (comment)
The text was updated successfully, but these errors were encountered: