Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsFiddle Demos do not work #9529

Closed
N-M opened this issue Mar 5, 2018 · 5 comments
Closed

JsFiddle Demos do not work #9529

N-M opened this issue Mar 5, 2018 · 5 comments

Comments

@N-M
Copy link

N-M commented Mar 5, 2018

Example on http://jsfiddle.net/pdfjs/9engc9mw/ provided in interactive examples does not work.
PDFJS is not defined error is presented

@timvandermeij
Copy link
Contributor

/cc @yurydelendik for updating the JSFiddle examples with the new code.

@yurydelendik
Copy link
Contributor

Updated, waiting for cache to catch up

@yurydelendik
Copy link
Contributor

@timvandermeij can you verify if I used proper API to access worker settings?

@timvandermeij
Copy link
Contributor

timvandermeij commented Mar 7, 2018

Looks good to me, thanks! Closing as fixed.

@Rob--W
Copy link
Member

Rob--W commented Mar 10, 2018

@yurydelendik The jsfiddle example imports PDF.js using window['pdfjs-dist/build/pdf'].
That is very unidiomatic. There is also a global symbol called pdfjsDistBuildPdf, which would be more natural, but still the name is a bit verbose. Can you replace the former with the latter, at least?

While writing documentation (#9528), I came across the fact that there is no short and obvious name for to access the library. Before submitting a documentation update, I have opened a new ticket to request a better name at #9545.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants