-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that the viewer waits for the library to complete loading (issue 17228) #17255
Conversation
…ue 17228) This should *hopefully* fix 17228, by tweaking the build scripts to give the GENERIC viewer something to await to avoid breaking third-party users of the standalone viewer components.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/790f86210007488/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/790f86210007488/output.txt Total script time: 1.37 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a20c848edcea568/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/36fcd84350ab45e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/36fcd84350ab45e/output.txt Total script time: 24.72 mins
Image differences available at: http://54.241.84.105:8877/36fcd84350ab45e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a20c848edcea568/output.txt Total script time: 26.66 mins
Image differences available at: http://54.193.163.58:8877/a20c848edcea568/reftest-analyzer.html#web=eq.log |
Locally I've tried changing pdf.js/examples/components/simpleviewer.html Lines 40 to 41 in 8e5311e
<script type="module">
import "../../node_modules/pdfjs-dist/build/pdf.mjs";
import "../../node_modules/pdfjs-dist/web/pdf_viewer.mjs";
</script> That failed when testing against |
Let's do this; thank you! |
This should hopefully fix #17228, by tweaking the build scripts to give the GENERIC viewer something to await to avoid breaking third-party users of the standalone viewer components.