Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the viewer waits for the library to complete loading (issue 17228) #17255

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

This should hopefully fix #17228, by tweaking the build scripts to give the GENERIC viewer something to await to avoid breaking third-party users of the standalone viewer components.

…ue 17228)

This should *hopefully* fix 17228, by tweaking the build scripts to give the GENERIC viewer something to await to avoid breaking third-party users of the standalone viewer components.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/790f86210007488/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/790f86210007488/output.txt

Total script time: 1.37 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a20c848edcea568/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/36fcd84350ab45e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/36fcd84350ab45e/output.txt

Total script time: 24.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 19
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/36fcd84350ab45e/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/a20c848edcea568/output.txt

Total script time: 26.66 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/a20c848edcea568/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

Locally I've tried changing

<script src="../../node_modules/pdfjs-dist/build/pdf.mjs" type="module"></script>
<script src="../../node_modules/pdfjs-dist/web/pdf_viewer.mjs" type="module"></script>
into

<script type="module">
  import "../../node_modules/pdfjs-dist/build/pdf.mjs";
  import "../../node_modules/pdfjs-dist/web/pdf_viewer.mjs";
</script> 

That failed when testing against master, but worked with this patch.

@timvandermeij timvandermeij merged commit 290b483 into mozilla:master Nov 12, 2023
5 checks passed
@timvandermeij
Copy link
Contributor

Let's do this; thank you!

@Snuffleupagus Snuffleupagus deleted the issue-17228 branch November 12, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdf_viewer broken in 4.0.189 when using Webpack
3 participants