-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Avoid conflicts between new persistent refs and the ones created when saving (bug 1865341) #17374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does feel a tiny bit "hacky", but given that it's limited to a small part of the code-base I suppose that it's fine.
r=me, with passing tests; thank you!
…ated when saving (bug 1865341) When a pdf as a FreeText without appearance, we use a fake font in order to render it and that leads to create few new refs for the font. But then when we're saving, we create some new refs which start at the same number as the previous created ones. Consequently, when saving we're using some wrong objects (like a font) to check if we're able to render the newly added FreeText. In order to fix this bug, we just remove the persistent refs (which are only used when rendering/printing) during the saving.
837f1c3
to
ae5828c
Compare
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/de50a91ec6cd50c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0a465c44e7e1929/output.txt |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/09aa820cb3cade8/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/d465ac9dc3e736d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0a465c44e7e1929/output.txt Total script time: 5.59 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/de50a91ec6cd50c/output.txt Total script time: 16.20 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d465ac9dc3e736d/output.txt Total script time: 24.42 mins
Image differences available at: http://54.241.84.105:8877/d465ac9dc3e736d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/09aa820cb3cade8/output.txt Total script time: 33.97 mins
Image differences available at: http://54.193.163.58:8877/09aa820cb3cade8/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/640b98a9e2a5eac/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/309314eb5daf1b8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/309314eb5daf1b8/output.txt Total script time: 18.32 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/640b98a9e2a5eac/output.txt Total script time: 23.10 mins
|
When a pdf as a FreeText without appearance, we use a fake font in order to render it and that leads to create few new refs for the font. But then when we're saving, we create some new refs which start at the same number as the previous created ones.
Consequently, when saving we're using some wrong objects (like a font) to check if we're able to render the newly added FreeText.
In order to fix this bug, we just remove the persistent refs (which are only used when rendering/printing) during the saving.