Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the internal "toolbarreset"/"secondarytoolbarreset" events and slightly re-factor the code #17464

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Remove the internal "toolbarreset"/"secondarytoolbarreset" events and slightly re-factor the code #17464

merged 2 commits into from
Dec 29, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus
Remove the internal "toolbarreset" event and slightly re-factor the code
234b57b 
With modern JavaScript class features we can move the relevant event handling into private methods, and thus invoke it directly when resetting the toolbar UI-state.

*Please note:* This patch slightly reduces the size of the `web/toolbar.js` file.
@Snuffleupagus
Remove the internal "secondarytoolbarreset" event and slightly re-fac…
b1ca270 
…tor the code

With modern JavaScript class features we can move the relevant event handling into private methods, and thus invoke it directly when resetting the toolbar UI-state.

*Please note:* This patch slightly reduces the size of the `web/secondary_toolbar.js` file.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7d18ca2caa2fd33/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7d18ca2caa2fd33/output.txt

Total script time: 1.45 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c6bdcbb3d380d4f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9124bac7c6c1538/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c6bdcbb3d380d4f/output.txt

Total script time: 5.94 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9124bac7c6c1538/output.txt

Total script time: 14.70 mins

  • Integration Tests: Passed

@timvandermeij timvandermeij merged commit 9e14d04 into mozilla:master Dec 29, 2023
7 checks passed
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the rm-toolbar-reset-events branch December 29, 2023 12:15
@Snuffleupagus Snuffleupagus mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @timvandermeij