Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the internal "toolbarreset"/"secondarytoolbarreset" events and slightly re-factor the code #17464

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Remove the internal "toolbarreset"/"secondarytoolbarreset" events and slightly re-factor the code #17464

merged 2 commits into from
Dec 29, 2023

Commits on Dec 26, 2023

  1. Remove the internal "toolbarreset" event and slightly re-factor the code 

    With modern JavaScript class features we can move the relevant event handling into private methods, and thus invoke it directly when resetting the toolbar UI-state.

*Please note:* This patch slightly reduces the size of the `web/toolbar.js` file.
    @Snuffleupagus
    Snuffleupagus committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    234b57b View commit details
    Browse the repository at this point in the history

  2. Remove the internal "secondarytoolbarreset" event and slightly re-fac… 

    …tor the code

With modern JavaScript class features we can move the relevant event handling into private methods, and thus invoke it directly when resetting the toolbar UI-state.

*Please note:* This patch slightly reduces the size of the `web/secondary_toolbar.js` file.
    @Snuffleupagus
    Snuffleupagus committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    b1ca270 View commit details
    Browse the repository at this point in the history