Improve the implementation of the PDFDocument.fingerprints-getter
#17862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixteman
reviewed
Apr 1, 2024
Snuffleupagus
force-pushed
the
fingerprints-toHex
branch
from
6e71445
to
4fd2419
Compare
Snuffleupagus
force-pushed
the
fingerprints-toHex
branch
from
4fd2419
to
87bc34c
Compare
Snuffleupagus
force-pushed
the
fingerprints-toHex
branch
from
87bc34c
to
112fa73
Compare
Snuffleupagus
force-pushed
the
fingerprints-toHex
branch
4 times, most recently
from
844cf02
to
2598a0b
Compare
Snuffleupagus
force-pushed
the
fingerprints-toHex
branch
2 times, most recently
from
c3e02cd
to
825d3f2
Compare
- Add explicit `length` validation of the /ID entries. Given the `EMPTY_FINGERPRINT` constant we're already *implicitly* assuming a particular length. - Move the constants into the `fingerprints`-getter, since they're not used anywhere else. - Replace the `hexString` helper function with the standard `Uint8Array.prototype.toHex` method; see https://github.com/tc39/proposal-arraybuffer-base64
…se64` usage in the main code-base See https://github.com/tc39/proposal-arraybuffer-base64
This allows using the new methods in browsers that support them, e.g. Firefox 133+, while still providing fallbacks where necessary; see https://github.com/tc39/proposal-arraybuffer-base64 *Please note:* These are not actual polyfills, but only implements what we need in the PDF.js code-base. Eventually this patch should be reverted, once support is generally available.
Snuffleupagus
force-pushed
the
fingerprints-toHex
branch
from
825d3f2
to
8f47d06
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ebb2c4843e3db36/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6273c2632b50cf7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ebb2c4843e3db36/output.txt Total script time: 30.65 mins
Image differences available at: http://54.241.84.105:8877/ebb2c4843e3db36/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6273c2632b50cf7/output.txt Total script time: 46.16 mins
|
calixteman
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit
lengthvalidation of the /ID entries. Given theEMPTY_FINGERPRINTconstant we're already implicitly assuming a particular length.Move the constants into the
fingerprints-getter, since they're not used anywhere else.Replace the
hexStringhelper function with the standardUint8Array.prototype.toHexmethod; see https://github.com/tc39/proposal-arraybuffer-base64