Validate even more dictionary properties #18026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
validate-more-getArray
branch
3 times, most recently
from
48708f6
to
1764c0c
Compare
Snuffleupagus
force-pushed
the
validate-more-getArray
branch
from
1764c0c
to
14707f9
Compare
Snuffleupagus
force-pushed
the
validate-more-getArray
branch
from
14707f9
to
e37dcaa
Compare
This checks primarily Arrays, but also some other properties, that we'll end up sending (sometimes indirectly) to the main-thread.
Snuffleupagus
force-pushed
the
validate-more-getArray
branch
from
e37dcaa
to
9b41bfc
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8d7e7463a90ea1c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d21bb2f83ca8eb8/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8d7e7463a90ea1c/output.txt Total script time: 27.60 mins
Image differences available at: http://54.241.84.105:8877/8d7e7463a90ea1c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d21bb2f83ca8eb8/output.txt Total script time: 42.12 mins
Image differences available at: http://54.193.163.58:8877/d21bb2f83ca8eb8/reftest-analyzer.html#web=eq.log |
calixteman
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks primarily Arrays, but also some other properties, that we'll end up sending (sometimes indirectly) to the main-thread.