Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openjpeg build (bug 1896577) #18087

Merged
merged 1 commit into from
May 14, 2024

Conversation

calixteman
Copy link
Contributor

It just contains fixes for:

It just contains fixes for:
 - bug 1896577
 - mozilla/pdf.js.openjpeg#1
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/46116657deceb1d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/3609e19cd4a7acb/output.txt

@Rob--W
Copy link
Member

Rob--W commented May 14, 2024

The _scriptDir (pre patch) / _scriptName (post patch) variable is used to populate the scriptDirectory variable, which is not used anywhere (at least no references to it other than assignment). document.currentScript is already used inside the code to populate scriptDirectory, before unconditionally replacing it with the value of _scriptDir.

@calixteman Why did you introduce _scriptName instead of deleting the use of _scriptDir?

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/46116657deceb1d/output.txt

Total script time: 27.52 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/46116657deceb1d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/3609e19cd4a7acb/output.txt

Total script time: 40.81 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8

Image differences available at: http://54.193.163.58:8877/3609e19cd4a7acb/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

The _scriptDir (pre patch) / _scriptName (post patch) variable is used to populate the scriptDirectory variable, which is not used anywhere (at least no references to it other than assignment). document.currentScript is already used inside the code to populate scriptDirectory, before unconditionally replacing it with the value of _scriptDir.

@calixteman Why did you introduce _scriptName instead of deleting the use of _scriptDir?

Unfortunately, almost all the js in this file is generated by emscripten.
The only js I added is:

So it's a bug in emscripten.

@timvandermeij timvandermeij merged commit 33f3228 into mozilla:master May 14, 2024
7 checks passed
@timvandermeij
Copy link
Contributor

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants