Disable new tab page stuff in Firefox when running tests #18356
Conversation
It should help to have such a garbage in the logs: ``` console.warn: TopSitesFeed: Failed to fetch data from Contile server: NetworkError when attempting to fetch resource. JavaScript error: , line 0: TypeError: NetworkError when attempting to fetch resource. ```
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5a93fb86c60dd0b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/83152bf1cf8cd9f/output.txt |
|
Out of curiosity, where have you seen those logs? I don't have them locally (the new tab page is empty if I manually open one in the headful test browser) and I also don't recall having seen them on the bots. |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5a93fb86c60dd0b/output.txt Total script time: 7.92 mins
|
|
I'm running the tests on Windows but from an Ubuntu within WSL2. |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/83152bf1cf8cd9f/output.txt Total script time: 19.10 mins
|
|
That said in general it's probably not that bad to remove the small overhead due to the new tab page stuff. |
|
Looks like a good idea to me; thanks! |
In PR mozilla#18356 the new tab page logic was disabled to prevent Firefox from logging failed network connections to Contile, the Mozilla Tiles service that is used for the new tab page [1]. However, recently this log reappeared locally and on the bots: ``` console.warn: TopSitesFeed: Failed to fetch data from Contile server: NetworkError when attempting to fetch resource. ``` It looks like Contile communication is also triggered from other places in Firefox such as the URL bar [2], so this commit fixes the issue by disabling network connections to Contile [3] altogether regardless of their origin within Firefox. Note that we don't revert the change from PR mozilla#18356 because as noted in [4] it can't hurt to keep that disabled too to avoid overhead for a feature we don't use in the tests. [1] https://github.com/mozilla-services/contile [2] https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarProviderTopSites.sys.mjs#38 [3] https://github.com/mozilla/gecko-dev/blob/196ef8360e4d3b5c334f1f8f91b3b1fdb434eb63/browser/components/newtab/lib/TopSitesFeed.sys.mjs#L111 [4] mozilla#18356 (comment)
In PR mozilla#18356 the new tab page logic was disabled to prevent Firefox from logging failed network connections to Contile, the Mozilla Tiles service that is used for the new tab page [1]. However, recently this log reappeared locally and on the bots: ``` console.warn: TopSitesFeed: Failed to fetch data from Contile server: NetworkError when attempting to fetch resource. ``` It looks like Contile communication is also triggered from other places in Firefox such as the URL bar [2], so this commit fixes the issue by disabling network connections to Contile [3] altogether regardless of their origin within Firefox. Note that we don't revert the change from PR mozilla#18356 because as noted in [4] it can't hurt to keep that disabled too to avoid overhead for a feature we don't use in the tests. [1] https://github.com/mozilla-services/contile [2] https://github.com/mozilla/gecko-dev/blob/196ef8360e4d3b5c334f1f8f91b3b1fdb434eb63/browser/components/urlbar/UrlbarProviderTopSites.sys.mjs#L38 [3] https://github.com/mozilla/gecko-dev/blob/196ef8360e4d3b5c334f1f8f91b3b1fdb434eb63/browser/components/newtab/lib/TopSitesFeed.sys.mjs#L111 [4] mozilla#18356 (comment)
It should help to have such a garbage in the logs: