-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Make editor toolbars usable whatever their z-index (bug 1879104) #18425
Conversation
…104) Because of editor z-index, the toolbar belonging to an highlight created before a second adjacent one, can be overlapped by this new one. So when the user select an editor we just show it on front of all the other ones to make sure that it can be used normally.
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/deb46b1d08f6f19/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/efd7956a1b8cf36/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/efd7956a1b8cf36/output.txt Total script time: 8.42 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/deb46b1d08f6f19/output.txt Total script time: 17.94 mins
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/069aafad6e9e709/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/069aafad6e9e709/output.txt Total script time: 17.77 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
Because of editor z-index, the toolbar belonging to an highlight created before a second adjacent one, can be overlapped by this new one.
So when the user select an editor we just show it on front of all the other ones to make sure that it can be used normally.