Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Babel plugin to remove empty static blocks #18562

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion external/builder/babel-plugin-pdfjs-preprocessor.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function babelPluginPDFJSPreprocessor(babel, ctx) {
path.replaceWith(t.importExpression(source));
}
},
BlockStatement: {
"BlockStatement|StaticBlock": {
// Visit node in post-order so that recursive flattening
// of blocks works correctly.
exit(path) {
Expand Down Expand Up @@ -215,6 +215,10 @@ function babelPluginPDFJSPreprocessor(babel, ctx) {
}
subExpressionIndex++;
}

if (node.type === "StaticBlock" && node.body.length === 0) {
path.remove();
}
},
},
Function: {
Expand Down
8 changes: 8 additions & 0 deletions external/builder/fixtures_babel/staticblock-expected.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
class A {
Fixed Show fixed Hide fixed
Dismissed Show dismissed Hide dismissed
static {
foo();
}
static {
var a = 0;
}
}
20 changes: 20 additions & 0 deletions external/builder/fixtures_babel/staticblock.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
class A {
Fixed Show fixed Hide fixed
Dismissed Show dismissed Hide dismissed
static {}
static {
{ foo() }
}
static {
{;}
}
static {
if (PDFJSDev.test('TRUE')) {
var a = 0;
}
}

static {
if (PDFJSDev.test('FALSE')) {
var a = 1;
}
}
}