Use standard glyph mapping for non-embedded and non-composite Calibri fonts (issue 18208) #18628
Conversation
… fonts (issue 18208) Given that we handle non-embedded Calibri fonts as "mapped to standard font", we really ought to be able to use the same glyph mapping as for an actual standard font. Note that this actually improves consistency in the code, given how we already handle such fonts if they happen to be of the `CIDFontType2` type; see https://github.com/mozilla/pdf.js/blob/b47c7eca83c35b8f9ea170aa3742fc70359726c2/src/core/fonts.js#L1186-L1190
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d3c9cf08ddf5e41/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/45a0654f13ab497/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d3c9cf08ddf5e41/output.txt Total script time: 30.47 mins
Image differences available at: http://54.241.84.105:8877/d3c9cf08ddf5e41/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/45a0654f13ab497/output.txt Total script time: 47.63 mins
Image differences available at: http://54.193.163.58:8877/45a0654f13ab497/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ad23e9752fef145/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ad23e9752fef145/output.txt Total script time: 1.05 mins Published |
|
Thank you for fixing this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8a8156088a6bec5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/68799cc97862c4d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8a8156088a6bec5/output.txt Total script time: 20.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/68799cc97862c4d/output.txt Total script time: 26.31 mins
|
Given that we handle non-embedded Calibri fonts as "mapped to standard font", we really ought to be able to use the same glyph mapping as for an actual standard font.
Note that this actually improves consistency in the code, given how we already handle such fonts if they happen to be of the
CIDFontType2type; seepdf.js/src/core/fonts.js
Lines 1186 to 1190 in b47c7ec
Please note: I'm well aware that someone else expressed interest in working on this issue, however that was over a month ago and there's not been any updates since. Hence it's hopefully OK to "steal" the issue now.
Also, given just how complicated the topic of fonts in PDFs usually are that issue was probably never going to be a good beginner bug unfortunately.