-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and translations to the most recent versions #18708
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/24719fd8830d1d7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/24719fd8830d1d7/output.txt Total script time: 1.17 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/562f5aeb62a0629/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ead2a39d15183c3/output.txt |
Does that plugin actually support ESLint 9 now though, given that import-js/eslint-plugin-import#2948 is still open? |
You're right; looking at import-js/eslint-plugin-import#3018 confirms that this mainly lays the foundation for supporting ESLint 9, but that's indeed a separate issue. I have amended the PR description to reflect that. |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ead2a39d15183c3/output.txt Total script time: 30.71 mins
Image differences available at: http://54.241.84.105:8877/ead2a39d15183c3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/562f5aeb62a0629/output.txt Total script time: 46.14 mins
Image differences available at: http://54.193.163.58:8877/562f5aeb62a0629/reftest-analyzer.html#web=eq.log |
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/03f8178463347a2/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/03f8178463347a2/output.txt Total script time: 19.32 mins
|
ccd98db
to
e9bb2f2
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/609e0ca9b21af91/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/137c1a91e0f06c8/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/609e0ca9b21af91/output.txt Total script time: 31.03 mins
Image differences available at: http://54.241.84.105:8877/609e0ca9b21af91/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/137c1a91e0f06c8/output.txt Total script time: 46.54 mins
Image differences available at: http://54.193.163.58:8877/137c1a91e0f06c8/reftest-analyzer.html#web=eq.log |
e9bb2f2
to
440da0d
Compare
I have removed the Puppeteer update due to a couple of sudden integration test failures on Windows only (see http://54.193.163.58:8877/562f5aeb62a0629/output.txt). I'll create a follow-up issue to investigate that later. /botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b4fc4c92d0ee95b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7cf8c95961e3a98/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b4fc4c92d0ee95b/output.txt Total script time: 31.08 mins
Image differences available at: http://54.241.84.105:8877/b4fc4c92d0ee95b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7cf8c95961e3a98/output.txt Total script time: 46.62 mins
Image differences available at: http://54.193.163.58:8877/7cf8c95961e3a98/reftest-analyzer.html#web=eq.log |
Hm, it failed again, even without the Puppeteer update. It might then be caused by a browser update on the bots. I'll retry on a clean PR without any other changes to confirm. |
440da0d
to
2f2d74b
Compare
It turns out that the Windows failures are not caused by this PR, but are a regression from #18698 where they showed up in #18698 (comment) already. I have reverted this PR to the original state with the Puppeteer update again so this is now unblocked. /botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3a48efeaefadcfa/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f8d5c3b4a7ac62f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3a48efeaefadcfa/output.txt Total script time: 31.01 mins
Image differences available at: http://54.241.84.105:8877/3a48efeaefadcfa/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f8d5c3b4a7ac62f/output.txt Total script time: 46.58 mins
Image differences available at: http://54.193.163.58:8877/f8d5c3b4a7ac62f/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
Note that this is another step towards #17928 because
eslint-plugin-no-unsanitized
(see https://github.com/mozilla/eslint-plugin-no-unsanitized/releases/tag/4.1.0) now supports ESLint 9 andeslint-plugin-import
(see https://github.com/import-js/eslint-plugin-import/releases/tag/v2.30.0) now has support for flat configuration, which is a prerequisite for supporting ESLint 9 later on.