Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and translations to the most recent versions #18708

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Sep 8, 2024

Note that this is another step towards #17928 because eslint-plugin-no-unsanitized (see https://github.com/mozilla/eslint-plugin-no-unsanitized/releases/tag/4.1.0) now supports ESLint 9 and eslint-plugin-import (see https://github.com/import-js/eslint-plugin-import/releases/tag/v2.30.0) now has support for flat configuration, which is a prerequisite for supporting ESLint 9 later on.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/24719fd8830d1d7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/24719fd8830d1d7/output.txt

Total script time: 1.17 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/562f5aeb62a0629/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ead2a39d15183c3/output.txt

@Snuffleupagus
Copy link
Collaborator

[...] and eslint-plugin-import (see https://github.com/import-js/eslint-plugin-import/releases/tag/v2.30.0, the "add support for Flat Config" item) are now compatible with ESLint 9.

Does that plugin actually support ESLint 9 now though, given that import-js/eslint-plugin-import#2948 is still open?
While support for the Flat Config format is a pre-requisite for ESLint 9 compatibility, it may not be the only thing required.

@timvandermeij
Copy link
Contributor Author

You're right; looking at import-js/eslint-plugin-import#3018 confirms that this mainly lays the foundation for supporting ESLint 9, but that's indeed a separate issue. I have amended the PR description to reflect that.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ead2a39d15183c3/output.txt

Total script time: 30.71 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/ead2a39d15183c3/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/562f5aeb62a0629/output.txt

Total script time: 46.14 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/562f5aeb62a0629/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor Author

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/03f8178463347a2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/03f8178463347a2/output.txt

Total script time: 19.32 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/609e0ca9b21af91/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/137c1a91e0f06c8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/609e0ca9b21af91/output.txt

Total script time: 31.03 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 12
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/609e0ca9b21af91/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/137c1a91e0f06c8/output.txt

Total script time: 46.54 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 6

Image differences available at: http://54.193.163.58:8877/137c1a91e0f06c8/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor Author

I have removed the Puppeteer update due to a couple of sudden integration test failures on Windows only (see http://54.193.163.58:8877/562f5aeb62a0629/output.txt). I'll create a follow-up issue to investigate that later.

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b4fc4c92d0ee95b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7cf8c95961e3a98/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/b4fc4c92d0ee95b/output.txt

Total script time: 31.08 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 14

Image differences available at: http://54.241.84.105:8877/b4fc4c92d0ee95b/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/7cf8c95961e3a98/output.txt

Total script time: 46.62 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 6

Image differences available at: http://54.193.163.58:8877/7cf8c95961e3a98/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor Author

Hm, it failed again, even without the Puppeteer update. It might then be caused by a browser update on the bots. I'll retry on a clean PR without any other changes to confirm.

@timvandermeij timvandermeij marked this pull request as draft September 8, 2024 18:23
@timvandermeij timvandermeij marked this pull request as ready for review September 9, 2024 17:43
@timvandermeij timvandermeij marked this pull request as draft September 9, 2024 17:43
@timvandermeij
Copy link
Contributor Author

It turns out that the Windows failures are not caused by this PR, but are a regression from #18698 where they showed up in #18698 (comment) already. I have reverted this PR to the original state with the Puppeteer update again so this is now unblocked.

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3a48efeaefadcfa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f8d5c3b4a7ac62f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/3a48efeaefadcfa/output.txt

Total script time: 31.01 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 12
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/3a48efeaefadcfa/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/f8d5c3b4a7ac62f/output.txt

Total script time: 46.58 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 6

Image differences available at: http://54.193.163.58:8877/f8d5c3b4a7ac62f/reftest-analyzer.html#web=eq.log

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@timvandermeij timvandermeij merged commit 5f39b59 into mozilla:master Sep 9, 2024
6 checks passed
@timvandermeij timvandermeij deleted the updates branch September 9, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants