Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to gulp makeref/browsertest to only run tests with specific ids #18833

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add an option to gulp makeref/browsertest to only run tests with specific ids #18833

merged 1 commit into from
Oct 11, 2024

Conversation

calixteman
Copy link
Contributor

It can be used like this: gulp makeref -t tracemonkey-eq or gulp browsertest --testfilter tracemonkey-text.

Snuffleupagus
Snuffleupagus reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the new helper function seems quite general, are you planning on a follow-up to re-factor the existing code to use it more?

gulpfile.mjs Outdated Show resolved Hide resolved
@calixteman
Add an option to gulp makeref/browsertest to only run tests with spec…
6dd7726 
…ific ids

It can be used like this: `gulp makeref -t tracemonkey-eq` or `gulp browsertest --testfilter tracemonkey-text`.
@calixteman
Copy link
Contributor Author

Given that the new helper function seems quite general, are you planning on a follow-up to re-factor the existing code to use it more?

Yep I'm.

@Snuffleupagus
Copy link
Collaborator

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/86682a194eb2b5b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a60fceb7ca67093/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/86682a194eb2b5b/output.txt

Total script time: 20.58 mins

  • Regression tests: FAILED
  different ref/snapshot: 17
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/86682a194eb2b5b/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a60fceb7ca67093/output.txt

Total script time: 26.15 mins

  • Regression tests: FAILED
  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/a60fceb7ca67093/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 4a0c508 into mozilla:master Oct 11, 2024
8 checks passed
@calixteman calixteman deleted the gulp_testfilter branch October 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @Snuffleupagus @moz-tools-bot @timvandermeij