Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify localization of the "default-content" in FreeText editors #18920

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Simplify localization of the "default-content" in FreeText editors #18920

merged 1 commit into from
Oct 20, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Oct 19, 2024 •
edited
Loading

By using "data-l10n-attrs" it's possible to instruct Fluent to localize custom attributes, which means that we don't need to manually translate/update the "default-content" in FreeText editors.

Edit: The patch also seems to work fine in a local artifact build of Firefox.

@Snuffleupagus Snuffleupagus added editor l10n Localization labels Oct 19, 2024
@Snuffleupagus Snuffleupagus requested a review from a team as a code owner October 19, 2024 10:39
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b9be41b4265d6fa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/b9be41b4265d6fa/output.txt

Total script time: 1.00 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2b9f89e2964263c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/85266f6b97f7dc0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2b9f89e2964263c/output.txt

Total script time: 9.24 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/85266f6b97f7dc0/output.txt

Total script time: 20.92 mins

  • Integration Tests: FAILED

flodolo
flodolo approved these changes Oct 20, 2024
View reviewed changes
l10n/en-US/viewer.ftl Show resolved Hide resolved
timvandermeij
timvandermeij approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the comment below addressed. Thank you for simplifying this!

src/display/editor/freetext.js Show resolved Hide resolved
@Snuffleupagus Snuffleupagus removed the request for review from calixteman October 20, 2024 16:34
@Snuffleupagus
Simplify localization of the "default-content" in FreeText editors
2ef3fd2 
By using "data-l10n-attrs" it's possible to instruct Fluent to localize *custom* attributes, which means that we don't need to manually translate/update the "default-content" in FreeText editors.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/30bf36234d8301b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e6bd931d3532c3c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/30bf36234d8301b/output.txt

Total script time: 9.23 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e6bd931d3532c3c/output.txt

Total script time: 20.65 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus merged commit 9c6f85f into mozilla:master Oct 20, 2024
11 checks passed
@Snuffleupagus Snuffleupagus deleted the FreeText-l10n-default-content branch October 20, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
editor l10n Localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @moz-tools-bot @timvandermeij @flodolo