Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-minor] Update the canvas package to version 3 #18922

Merged
merged 2 commits into from
Oct 20, 2024
Merged

[api-minor] Update the canvas package to version 3 #18922

merged 2 commits into from
Oct 20, 2024

Commits on Oct 20, 2024

  1. [api-minor] Update the canvas package to version 3 

    This allows us to run the Node.js unit-tests in version 22, which is good since it'll very soon become the active LTS release; see https://github.com/nodejs/release#release-schedule.
    @Snuffleupagus
    Snuffleupagus committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    6ae13fa View commit details
    Browse the repository at this point in the history

  2. Catch errors when invoking applyPath2DToCanvasRenderingContext 

    This way we allow the rest of the packages to be loaded successfully, such that e.g. the Node.js unit-tests work correctly.

Note that this occurred after updating the `node-canvas` package to version `3.0.0-rc2`, however it's not immediately clear to me if it's a problem there or in the `path2d` package; see also nilzona/path2d-polyfill/issues/84.
    @Snuffleupagus
    Snuffleupagus committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    54e00b0 View commit details
    Browse the repository at this point in the history