Simplify the getUuid helper function
#19084
Merged
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can remove most feature testing from this helper function, with the exception of `randomUUID` since that's only available in "secure contexts", and also remove the fallback code-path. Note that this code was only added for Node.js compatibility, and it's no longer necessary now that the minimum support version is `20`; see also https://developer.mozilla.org/en-US/docs/Web/API/Crypto#browser_compatibility Finally, this patch also adds a basic unit-test for the helper function.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/545ec70fbfa514d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6ecb8af55839d9c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6ecb8af55839d9c/output.txt Total script time: 30.61 mins
Image differences available at: http://54.241.84.105:8877/6ecb8af55839d9c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/545ec70fbfa514d/output.txt Total script time: 46.40 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can remove most feature testing from this helper function, with the exception of
randomUUIDsince that's only available in "secure contexts", and also remove the fallback code-path.Note that this code was only added for Node.js compatibility, and it's no longer necessary now that the minimum support version is
20; see also https://developer.mozilla.org/en-US/docs/Web/API/Crypto#browser_compatibilityFinally, this patch also adds a basic unit-test for the helper function.