Format button and autocomplete checkbox should be always displayed

[madalincm]

Steps to Reproduce:

1. Open new query page: https://pipeline-sql.stage.mozaws.net/queries/new
2. Observe the layout.

Expected results:

The buttons are always displayed, the user has an easy access to all of them.

Actual results:

The user needs to hover inside the section where he writes the query for the Format button and autocomplete checkbox to be displayed

Notes/Issues:

Build identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Verified in FF58(Win7). Issue can be reproduced in STMO-stage

[alison985]

This is reproducible on https://pipeline-sql.stage.mozaws.net/ today.

[alison985]

Upstream it's now a format button and there is no auto-complete checkbox. I'm submitting the change upstream ( getredash#2588 ) and we can port it back.

[alison985]

Related to getredash#2644

[kocsmy]

I'm just wondering: is the auto-complete checkbox something that needs to be visible all the time (or more like a global settings that will be toggled once in a while)?

I'm wondering how could we find a place in the interface that can scale well with future improvements without over-populating the editor area.

If this will be a frequently used feature, it can go next to the new Parameters and Format buttons below the editor in getredash#2644

If it's a less important, maybe we'll need to introduce a new dropdown menu close to the editor where we can add things like this and even more later.

[alison985]

@jezdez FYI about the comment above.

[jezdez]

@alison985 Thank you!

@kocsmy Excellent points, scaling this high-density UI is tricky and is very likey to become more complicated the more the Redash query editor grows.

Especially with plans to add more support for frontend extensions (similar to the backend extensions) that our custom autocomplete checkbox could use, I would say the area next to the new Parameters and Format buttons like in getredash#2644 is hard to handle without adding an overflow technique like a dropdown. That said maybe we can table the scaling issue of that new area till a later date and just deal with the currently existing features.

So in short: +1 on your idea to implement it like in getredash#2644.

[jezdez]

getredash#2709 has moved the format button to the new area below the query textarea following getredash#2644.

I'm closing this now since porting the autocomplete toggle to upstream is tracked in #460.

[vcarciu]

Verified as fixed :